Introduces .303 British as a calibre

[DoctorBoomstick]

Summary

Content "adds .303 British as an ammo type in the game, plus corresponding FMJ, SP, and BTHP rounds, craft recipes, item groups, migrations, and the SMLE Mk III and No. 4 Mk I rifles"

Purpose of change

Whilst less common than other calibres, .303 is still a cartridge which is produced and shot for recreational and hunting purposes. Similarly, Enfield rifles are also commendably prolific collector guns. Apart for this and less importantly, I set a private challenge to myself to push out a First World War combat calibre with appropriate guns by November 11 at 11:11AM, given the historical circumstances and commemorations.

Describe the solution

I’ve added the .303 calibre as an in-game ammunition type. To this end, I’ve included boat-tailed hollo point, full metal jacketed boat-taled, and soft point rounds, plus their black powder and reloaded equivalents. Their crafting recipes have also been included, along with the Enfield Mk III and Enfield No. 4 Mk I battle rifles. All needed item groups have been included or otherwise sorted out, along with migrations and variants.

Describe alternatives you've considered

1. Adding the 8mm (7.92x57mm) Mauser ammo to the game along side or instead of the venerable .303. I went for .303 ultimately as it’s overall more prolific to find, and more recognisable as a whole. My apologies K98 Mauser rifles and MG42 machine guns, y’all are just going to have to wait for another future PR.
2. Adding more .303 guns as a whole, like the Ross Mk III rifles and the BREN and Lewis light machine guns. However, both in order to stick to my privately set 11:11 finish time and to keep the PR nice and bite sized, I decided to add the overall framework now and eventually more guns down the line in other, smaller PRs.
3. Simply not adding to the sacrificial pyre of the gun bloat mountain we’ve already become infamous for. However, I think gun bloat’s fun. Some other people think gun bloat’s fun. Glory to the gun bloat.

Testing

All elements have been bug tested on the latest experimental builds, with the game loading just fine.

Additional context

What follows is a list of resources I consulted for information on modern production .303, as well as a few other miscellaneous links I utilised to determine other needed information. https://www.hornady.com/ammunition/rifle/303-british-150-gr-sp?msclkid=f9d86fe3d11811ec91b5aaa8412d50ad#!/ https://topammomag.com/product/hornady-303-british-174gr-boattail-hollow-point-20-per-box/?msclkid=38fd0aa2d11a11eca23c11695209f1e8 https://www.ammoforsale.com/ammo-club/boat-tail-bullet/#:~:text=A%20boat%20tail%20bullet%20%28left%29%20next%20to%20a,it%20looks%20like%20the%20stern%20of%20a%20sailboat.?msclkid=22f4e7c1d11b11ecb25af5bcfb70fc76 303 Cal .3105 174 gr FMJ BT - Hornady Manufacturing, Inc ENFIELD 303 NO1 MK III New and Used Price, Value, & Trends 2022 (truegunvalue.com)

[DoctorBoomstick]

@TheShadowFerret, I was under the belief that, in order for merged variants to work and spawn correctly, you had to create a migration entry for them as can be seen with stuff like the Auto 5 shotgun, the M27, etc. As things stand, the No. 4 Mk I is a variant under the Mk III.

[TheShadowFerret]

I was under the belief that, in order for merged variants to work and spawn correctly, you had to create a migration entry for them as can be seen with stuff like the Auto 5 shotgun, the M27, etc. As things stand, the No. 4 Mk I is a variant under the Mk III.

Those other migrations are from old items being converted into variants of one item, new items don't need this(such as your previous #58933, which had no migration file). This migration references a phantom number4_mki, and can just be deleted without harming anything.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• An English darling and icon of the First World War, the Short Magazine Lee-Enfield Mk III was the standard issue battle rifle of the British commonwealth from 1907.  Chambered for .303 ammunition, the rifle makes use of ten-round detachable magazines.  With its full-length wooden handguard, brass buttplate, and smooth action, the Lee-Enfield cuts a recognizable profile in either the trenches of the Great War or the zombie-strewn wastelands.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a 174gr boat-tailed hollo-point bullet, the projectile’s boat tail shaped design gives it greater stability with less aerial drag over long ranges, making it favorable for competition shooting.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a 174gr boat-tailed hollo-point bullet, the projectile’s boat tail shaped design gives it greater stability with less aerial drag over long ranges, making it favorable for competition shooting. Similar to its early 19th century iteration, this cartridge has been loaded with black powder. Expect lower velocities, muzzle smoke, and a dirtier barrel if you fire it.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a 174gr boat-tailed hollo-point bullet, the projectile’s boat tail shaped design gives it greater stability with less aerial drag over long ranges, making it favorable for competition shooting. This one has been hand-reloaded by a survivor or perhaps a pre-Cataclysm hobbyist, leading to slightly inferior performance compared to factory-produced ammo.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a single core, 174gr full metal jacketed bullet, the projectile possesses a solid metal jacket that grants it the capability to punch through thicker material. This comes at the cost of virtually non-existent expansion, leading to less overall damage.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a single core, 174gr full metal jacketed bullet, the projectile possesses a solid metal jacket that grants it the capability to punch through thicker material. This comes at the cost of virtually non-existent expansion, leading to less overall damage. Similar to its early 19th century iteration, this cartridge has been loaded with black powder. Expect lower velocities, muzzle smoke, and a dirtier barrel if you fire it.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a single core, 174gr full metal jacketed bullet, the projectile possesses a solid metal jacket that grants it the capability to punch through thicker material. This comes at the cost of virtually non-existent expansion, leading to less overall damage. This one has been hand-reloaded by a survivor or perhaps a pre-Cataclysm hobbyist, leading to slightly inferior performance compared to factory-produced ammo.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a single core, 180gr soft-point bullet, the projectile features an open-tipped design manufactured from lead. This loading allows the round to undergo greater expansion upon striking targets, leading to larger wound channels.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a single core, 180gr soft-point bullet, the projectile features an open-tipped design manufactured from lead. This loading allows the round to undergo greater expansion upon striking targets, leading to larger wound channels. Similar to its early 19th century iteration, this cartridge has been loaded with black powder. Expect lower velocities, muzzle smoke, and a dirtier barrel if you fire it.
• The British empire's standard combat cartridge throughout the nineteenth and twentieth centuries, first as a bottlenecked black powder design before evolving into a spitzered, smokeless round, this is a modern produced .303 caliber cartridge. Loaded with a single core, 180gr soft-point bullet, the projectile features an open-tipped design manufactured from lead. This loading allows the round to undergo greater expansion upon striking targets, leading to larger wound channels. This one has been hand-reloaded by a survivor or perhaps a pre-Cataclysm hobbyist, leading to slightly inferior performance compared to factory-produced ammo.
• This is a vintage spike bayonet for the British Lee Enfield No. 4 rifle, featuring a distinct cruciform blade and socket-based mounting system.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[bombasticSlacks]

This looks good to me, could you add the barrel lengths to the guns? #64961 gives an example.

[DoctorBoomstick]

This looks good to me, could you add the barrel lengths to the guns? #64961 gives an example.

Certainly. Do I need to just add, "barrel_length": "assorted amount", in the gun JSON, or do I also need to fiddle around with the ammo? Not totally sure how this works. Also, side note, but on the matter of gun mods, does this barrel length business also work with mods not specifically assigned to the barrel slot of a weapon? Asking cause in #64934, I’m adding conversion kits which also can change their weapons’ barrel length, and those fit into the bore slot, and I’m wondering if this’ll be an issue.

[bombasticSlacks]

Certainly. Do I need to just add, "barrel_length": "assorted amount", in the gun JSON, or do I also need to fiddle around with the ammo? Not totally sure how this works. Also, side note, but on the matter of gun mods, does this barrel length business also work with mods not specifically assigned to the barrel slot of a weapon? Asking cause in https://github.com/CleverRaven/Cataclysm-DDA/pull/64934, I’m adding conversion kits which also can change their weapons’ barrel length, and those fit into the bore slot, and I’m wondering if this’ll be an issue.

was gonna talk with you about the conversion kits at some point.

for this PR just add barrel length, I'll comment on the conversion kit PR when I get a chance. Sorry been juggling a lot of project :)

[bombasticSlacks]

extra crafts giving you conflicts, sorry :(

[DoctorBoomstick]

extra crafts giving you conflicts, sorry :( Afraid I’m not spotting the issue. The ammo crafts look ok, and I can’t see anything that’s amiss, unless I accidentally overwrote some changes that I’m not aware of.

[DoctorBoomstick]

extra crafts giving you conflicts, sorry :( Afraid I’m not spotting the issue. The ammo crafts look ok, and I can’t see anything that’s amiss, unless I accidentally overwrote some changes that I’m not aware of.

Yes. I’m a dumb dumb. Just figured out what the mistake was. Please disregard this.

[DoctorBoomstick]

Looks like the failing tests are a result of something having to do with monster json, which I didn’t touch for this PR.

[bombasticSlacks]

are you okay with me rebasing this to try to fix the errors?

[DoctorBoomstick]

are you okay with me rebasing this to try to fix the errors.

Perfectly fine with that, cause for the life of me, I can’t tell what’s the issue. Apologies for being completely illiterate where GGIT is concerned and pestering you about this.

[bombasticSlacks]

barrel stuff looks good 😄