Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Vegan trait + extra clothes

Open Holli-Git opened this issue 2 years ago • 20 comments

Summary

Content "Vegan trait + more clothes"

Purpose of change

Wanted a bit more of a challenge tbh. Herbivore is neat, vegetarian is neat, but I wanted to see how a vegan survivor would go in the world.

Describe the solution

Added a vegan trait. Can't eat animal products, can't wear animal products. Added some faux fur equivalents and expanded some items to make it less of a hassle. The biggest concern for me is most likely the cotton holsters, as they're a much cheaper way to get holsters. I made them unable to hold as much weight and being made from cotton makes it weaker, but I do not know if there's something else I can do.

Describe alternatives you've considered

Not making it?

Testing

Lots. Tested that I couldn't wear items made with chitin, fur, leather, etc etc. Spawned in the clothes, wore em. Couldn't eat a food item with the "animal_product" flag. Mutating skins that are made of fur and such still work. Also first C++ so I had to do a lot of compiling.

Additional context

Holli-Git avatar Nov 11 '22 04:11 Holli-Git

Make the holsters from canvas? Tougher weave than cotton, with thicker threads too. Or even just use the "tactical holster" (made of nylon)

anoobindisguise avatar Nov 11 '22 19:11 anoobindisguise

I couldn't find anything regarding scabbards in the files, you could also add a non-leather scabbard. Nylon could be a potential material for it, I have one for my machete. (It could also be set to spawn with machetes in shops so they aren't kept in the open.)

Jarewill avatar Nov 11 '22 20:11 Jarewill

Make the holsters from canvas? Tougher weave than cotton, with thicker threads too. Or even just use the "tactical holster" (made of nylon)

Good idea! I'll get on that

Holli-Git avatar Nov 11 '22 22:11 Holli-Git

I couldn't find anything regarding scabbards in the files, you could also add a non-leather scabbard. Nylon could be a potential material for it, I have one for my machete. (It could also be set to spawn with machetes in shops so they aren't kept in the open.)

Honestly I just didn't feel like dealing with the scabbards/baldrics right now. I can get to it in awhile, but this PR has got me stressed lol.

Holli-Git avatar Nov 11 '22 22:11 Holli-Git

Does it make sense to be vegan in a world with no industry left? Wearing that leather jacket is not supporting the leather industry anymore

Fris0uman avatar Nov 12 '22 10:11 Fris0uman

Uh, what does industry have to do with being vegan??

Zireael07 avatar Nov 12 '22 10:11 Zireael07

Yeah, theres multiple reasons for being vegan. One that is still valid in a world with no more industry is that you do not wish to steal a chickens unhatched young or cows baby feed.

NetSysFire avatar Nov 12 '22 11:11 NetSysFire

Wonders if triffids are truely vegan

TheShadowFerret avatar Nov 12 '22 17:11 TheShadowFerret

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A really long faux fur scarf, worn over the mouth for warmth. With the extra length, it's enough to handle nonstandard facial features and accommodate your hands too. Use it to loosen it if you get too warm.
  • A really long faux fur scarf, worn over the mouth for warmth. With the extra length, it's enough to handle nonstandard facial features and accommodate your hands too. Use it to wear it tighter if you get too cold.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

github-actions[bot] avatar Nov 12 '22 18:11 github-actions[bot]

Probably too hard to add, but there are two things that can partly circumvent the trait.

  • Using sinew as thread (out of scope?)
  • Putting fur/wool stuff on the floor so you can still get warmth while sleeping or otherwise resting. This also does not prevent you from using a fur blanket to sleep.

I don't think those are possible, at least with my skillset

Holli-Git avatar Nov 13 '22 02:11 Holli-Git

The first one is pretty hard, yeah. The second one may be possible.

https://github.com/CleverRaven/Cataclysm-DDA/blob/45e6e56fb117f9e14783ee004ffa07ef79454868/src/character.cpp#L8252-L8263

NetSysFire avatar Nov 13 '22 02:11 NetSysFire

Uh, what does industry have to do with being vegan??

You're not supporting the massive exploitation of animal suffering anymore by consuming product made of animals in the pre cataclysm, becasue that system doesn't exist anymore. But I guess this is beside the point for this PR.

Fris0uman avatar Nov 14 '22 16:11 Fris0uman

@Fris0uman: That's only one of MANY reasons someone can be vegan. And that one, as you clearly mentioned yourself, no longer applies post-cataclysm

Zireael07 avatar Nov 14 '22 16:11 Zireael07

You're not supporting the massive exploitation of animal suffering anymore by consuming product made of animals in the pre cataclysm, becasue that system doesn't exist anymore. But I guess this is beside the point for this PR.

Some people also just don't like killing animals or are still uncomfortable with wearing leather. Like I do understand where you're coming from, but you can apply this logic to really any negative trait. Why would someone still hate grains if they're a good source of calories? Why would someone be pacifistic when you need to kill? Human behavior doesn't always follow what appears to be logical

Holli-Git avatar Nov 14 '22 17:11 Holli-Git

No one is saying vegan in Cataclysm is not logical, there's a ton of reasons that don't have to do with pre-catalysm stuff

Zireael07 avatar Nov 14 '22 18:11 Zireael07

No one is saying vegan in Cataclysm is not logical, there's a ton of reasons that don't have to do with pre-catalysm stuff

Whoops, misread, my apologies

Holli-Git avatar Nov 14 '22 20:11 Holli-Git

I love this but I think it should wait for stable.

I-am-Erk avatar Nov 24 '22 18:11 I-am-Erk

I love this but I think it should wait for stable.

Alright!

Holli-Git avatar Nov 24 '22 20:11 Holli-Git

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Dec 24 '22 22:12 github-actions[bot]

This needs conflicts fixed, but other than that I think this is ready for primetime

LyleSY avatar Mar 03 '23 01:03 LyleSY

Can you add looks_like to the new items that don't have one please?

Fris0uman avatar Mar 08 '23 11:03 Fris0uman

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Apr 07 '23 12:04 github-actions[bot]