More gun variants, part the third.

[DoctorBoomstick]

Summary

None

Purpose of change

Continues work started in #61598 and #61893, carrying on the inexorable march towards extending the variants system across more firearms which currently lack a more generic variation.

Describe the solution

I’ve created variants for all the weapons in .22 calibre, 7.62x25mm, 9x18mm, and 5.7x28mm. I’ve also slightly adjusted the existing variants present across the 5.7mm guns (the FN P90, Kel-Teck P50, and FN PS90), to make the names more compact and the descriptions less wordy. In doing these changes, many of the magazines have also been given appropriate variants were applicable.

Describe alternatives you've considered

No real alternatives to speak of, save for perhaps finding ways to cut down on the number of magazine variants.

Testing

All elements have been bug tested on the latest experimental builds, with the game loading just fine.

Additional context

Consult #61598 and #61893 for the first two parts to this expansion of the existing gun variants.

[nopenoperson]

i read the first pr and i dont really understand the problem that this is trying to fix. also the variant system makes sense for t shirts, not for mosin nagants made 100 years apart with wildly different materials and qa standards. functionally different guns should have functionally different stats!

[DoctorBoomstick]

@nopenoperson, I’m not the one who implemented gun variants from the onset, so I might get the reasoning wrong and/ or fuck up the intended point. As such, I’d advise consulting Pr #46814 for further information about the system. That being said, as far as I understand, gun variants are aimed at cutting down on the gigantic number of similar, near-identical, functionally the same guns we currently have in the game. For some folks, coming across five different types of assault rifles that are basically the same save in name and description can be overwhelming, especially if they’re not versed in some basic gun terminology. The system can be toggled on to simplify matters for non-gun people who do not want to deal with many different types of practically the same gun, and/ or who don’t understand the weapon gun nut talk present in some of the descriptions and name. on the other hand, if you enjoy rolling around in heaps of different guns Scrooge Mick Duck style, you can just leave it off and have your armoury’s Werth of different guns. Why do variants make sense for t-shirts? Simply cause all it’s doing is changing around descriptors, an inconsequential element. Why does gun variants make sense for guns? Simply because it sometimes takes near-identical weapons gameplay wise, like the M9 and 90two, were the only real differences are a name, description, and a few teeny tiny grams of weight and ML of volume, and puts them together under one name. again, if you don’t like this, you can just turn it off. For types of variants like the ones added in this PR, you do not even have any merging going on. It literally just makes the names and descriptions simpler, easier to understand, and holds the player’s hand a little if they don’t know what some gun terminologies are meant to mean.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• .22 deringer pistol
• .22 deringer pistols
• A compact submachine gun hailing from Czechoslovakia during the Cold War, featuring a suppressively high rate of automatic fire and shooting the Soviet 9x18mm round.
• A compact, .22 caliber semi-automatic pistol. Built from aluminum and polymer componence, the weapon is lightweight and concealable. Unfortunately, much like its namesake, this pistol mostly poses a mild annoyance to most hostiles that the Cataclysm is liable to direct into your path.
• A dramatically uncommon automatic weapon, making use of high-capacity pan magazines and firing the low power .22 calibre cartridge: an unusual ammunition choice for a submachine gun. With negligible recoil on account of its modest cartridge and a suppressively high rate of fire, a burst of .22 LR rounds from this little machine gun can be best likened with a swarm of hornets… an incredibly angry swarm of hornets.
• A lightweight and modular pistol caliber hunting carbine, firing the low power .22 LR cartridge. Before the Cataclysm, a mix of high customizability, cheep ammunition, and low recoil made this a very popular varmint rifle amongst civilian shooters.
• Firing the armor-piercing 5.7x28mm round, this lightweight handgun was developed for NATO use as a sidearm capable of penetrating body armor. Its proprietary and nonprolific ammunition kept it comparatively rare amongst both civilian and militant use, but the gun’s ability to ignore most forms of conventional ballistic armor can’t be argued with. Given that its tiny bullets have next to no stopping power, its armor-penetrating capability comes at a considerable trade-off.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[bombasticSlacks]

~~This looks good to me, could you add the barrel lengths to the guns? #64961 gives an example.~~

wrong PR mb