Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Backport z-level drawing, the second take

Open sonphantrung opened this issue 2 years ago • 7 comments

Summary

Features "z-level drawing backported to BN"

Purpose of change

I want to see zeds from below, 2nd attempt of #61074

Describe the solution

Backport the change from BN by @joveeater, with a slightly few changes (the deprecated usage of g-> has been replaced)

Describe alternatives you've considered

Not do this

Testing

TODO:

  • [ ] Compile this successfully
  • [ ] Deal with problems inherited from the fact that BN's codebase is OLD
  • [ ] (maybe?) have ncurses support

Additional context

I am not a C++ guy

sonphantrung avatar Sep 30 '22 09:09 sonphantrung

I am not a C++ guy

I am a bit confused at how you plan to manage to get this to work without knowing how to actually code the feature

Fris0uman avatar Sep 30 '22 09:09 Fris0uman

I mean, I know how to deal with editing, tweaking the current code, but I'm fairly dumb in actually further extending the functionality of that same code

sonphantrung avatar Sep 30 '22 11:09 sonphantrung

I believe in you, little shark.

EternalKitten avatar Sep 30 '22 13:09 EternalKitten

This line do bother me a lot

sonphantrung avatar Oct 04 '22 05:10 sonphantrung

Hello, I am interested in tackling this problem, have you made any progress or noted any important problems?

Calavera20012 avatar Nov 22 '22 19:11 Calavera20012

Thanks! So far, I'm currently dealing with misc errors at compilation, which I don't have enough time to deal with for now.

sonphantrung avatar Nov 25 '22 11:11 sonphantrung

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Feb 17 '23 06:02 github-actions[bot]

before you make a single more commit on this pr, you need to address the concerns that kevin raised on the previous PR: https://github.com/CleverRaven/Cataclysm-DDA/pull/61074#issuecomment-1257085629

also if you're still just submitting changes and waiting to see what the tests here say instead of actually attempting to compile them yourself and testing locally, that also needs to stop. that's not what the system is for.

esotericist avatar Mar 30 '23 11:03 esotericist

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar May 04 '23 17:05 github-actions[bot]

Closing in favor of #65738

Fris0uman avatar Jun 02 '23 13:06 Fris0uman