Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Ability to count kills using EoC

Open GuardianDll opened this issue 3 years ago • 8 comments

Is your feature request related to a problem? Please describe.

I just wanted to make some stuff, but found there is no such ability in EoC

Solution you would like.

"u_kill" or "npc_kill" with ability to specify exact id(s), species, fraction or flag, both for monsters and for NPCs

GuardianDll avatar Sep 19 '22 19:09 GuardianDll

So what do your goals for this look like? What you want to do shapes how it would be set up.

So right now what you could do is create a death eoc for a specific monster which would increment a variable upon you killing it. If you only want to track a one or a few monsters this could work.

Achievements seem to track this, so another way might be to simply add a dialog condition for achievements or there system.

Ramza13 avatar Sep 19 '22 19:09 Ramza13

In my case i want to store killed monster and add them to variable, to use in the enchantments, that will be added in #60788 its different from calling EoC like amigara works, and i dont really know how achievements works to use it

GuardianDll avatar Sep 19 '22 19:09 GuardianDll

So the question is do you care about all killed monsters or just one or two types? If its just one or two it can be done right now with death eocs. If its more than that it probably makes sense to add c++ to handle it.

Ramza13 avatar Sep 19 '22 19:09 Ramza13

Any. Some stuff may use species as target, another would just check the process of killing, no matter is it nether creature, NPC, zombie or human. Maybe also adding a targeting by flag make it even better. At this moment i plan to use it in Xedra Evolved mod, but i believe it can also be used somewhere else

GuardianDll avatar Sep 19 '22 19:09 GuardianDll

Ahh in that case I'll add it to my todo list, might be a good chance to leverage all the achievements stuff as conditions.

Ramza13 avatar Sep 19 '22 19:09 Ramza13

I remember at least one (probably Lua-era) mod that cared about kills and triggered effects either on X kills of specific enemy type or X kills total so there are definite use cases

Zireael07 avatar Sep 20 '22 08:09 Zireael07

I remember at least one (probably Lua-era) mod that cared about kills and triggered effects either on X kills of specific enemy type or X kills total so there are definite use cases

https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/mods/stats_through_kills/modinfo.json

ZhilkinSerg avatar Sep 20 '22 21:09 ZhilkinSerg

Oh yes, count a danger points can also be reasonable

GuardianDll avatar Sep 20 '22 22:09 GuardianDll

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

github-actions[bot] avatar Mar 02 '23 14:03 github-actions[bot]