Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

[Magiclysm] Attunement messages

Open Maleclypse opened this issue 3 years ago • 3 comments

Summary

None

Purpose of change

Adds messages for the attunement on hit and hit you enchantments, so that the player can know when they are working and active. If they aren't messaging, they probably aren't working now. Fixes #59989

Describe the solution

Adds message and npc_message where appropriate. If it's totally invisible no npc_message only pc message.

Describe alternatives you've considered

None

Testing

TBD

Additional context

Maleclypse avatar Sep 17 '22 05:09 Maleclypse

@GuardianDll if you have a second let me know what you think of these messages?

Maleclypse avatar Sep 17 '22 05:09 Maleclypse

I don't really know is this a good idea, because it will make a mess out of player's log, spamming a message each time someome attack the player

GuardianDll avatar Sep 17 '22 07:09 GuardianDll

Honestly I’ve hated the attunements I’ve tried because it was hard to know if they worked. Every other trait that has these kinds of effects has a message I thought. This would put them in line with other traits. It’s possible I’m just confused by every other ascii game with on hit effects using message logs to let you know things work.

Maleclypse avatar Sep 17 '22 14:09 Maleclypse