Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Moving items from a container using AIM seems to be broken

Open x-qq opened this issue 2 years ago • 1 comments

Describe the bug

Advanced Inventory Manager system does not seem to allow manipulating items inside a container.

Steps to reproduce

  1. Spawn a new character.
  2. Spawn "messenger bag", "pair of combat boots", "pair of sneakers".
  3. Insert boots and sneakers into the messenger bag.
  4. Drop messenger bag to the adjacent tile.
  5. Now attempt to move both items from inside the messenger bag to some other AIM location like your inventory or another tile by selecting the messenger bag and using the C key.
  6. Notice that AIM is not showing all of the bag contents.

Expected behavior

Selecting a container (possibly a nested container) in AIM and pressing C should display all contents of this container.

Screenshots

Bag contents in 'get' menu: get

Contents of the same bag in AIM: aim

Versions and configuration

Game version: cdda-linux-tiles-x64-2022-08-06-2052 Mod list: default

Additional context

No response

x-qq avatar Aug 06 '22 23:08 x-qq

/confirmed

  • OS: Linux
    • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 36 (Thirty Six); Release: 36; Codename: ThirtySix;
  • Game Version: df06cbf [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions] ]

hexagonrecursion avatar Aug 08 '22 05:08 hexagonrecursion

I've been experiencing this in builds since at least may -- I guess it's been that way ever since nested containers were introduced?

nadavwr avatar Aug 29 '22 16:08 nadavwr

I believe the culprit is in advanced_inv_pane, where this advanced_inv_listitem constructor is only being fed a single item_location, rather than a list of them. I'm unsure how to fix this myself, however. https://github.com/CleverRaven/Cataclysm-DDA/blob/51f9ad845ff6d0d446aa7d721d0f3e9406b81885/src/advanced_inv_pane.cpp#L227

Kamayana avatar Nov 28 '22 02:11 Kamayana