Steel crafting improvements

[Drew4484]

Summary

Content "Improvements to carbon steel crafting and repairs"

Purpose of change

Allows basecamps to craft various grades of carbon steel lumps, chunks, wire, and link sheets. Adds welding blankets, used to craft a welding kit. Welding kit allows for repairs to tempered steels. Adds a small increase to the cut/bash/ballistic values of the carbon steels (1/1/1.5).

Describe the solution

• [x] Add recipes to basecamp craft lists.
• [x] Add asbestos
• [x] Add welding blanket
• [x] Add welding kit
• [x] Remove tempered repairs from arc welder and makeshift arc welder.
• [x] Add tempered repairs to new welding kit.

Describe alternatives you've considered

None

Testing

Additional context

[PatrikLundell]

I don't like it because the list is already severely bloated, and the UI is very poor at handling long lists. The issue is not the recipes themselves, but the poor UI that's not really able to handle them in a usable manner. There's a need for a basecamp crafting UI overhaul that's similar to the regular crafting UI with categories and search functionality before it can handle any significant additions. That task would take someone who knows what to replace uilist with (and how to do that).

[Drew4484]

I don't like it because the list is already severely bloated, and the UI is very poor at handling long lists. The issue is not the recipes themselves, but the poor UI that's not really able to handle them in a usable manner. There's a need for a basecamp crafting UI overhaul that's similar to the regular crafting UI with categories and search functionality before it can handle any significant additions. That task would take someone who knows what to replace uilist with (and how to do that).

You can open an issue for UI suggestions, but UI issues should not stop all new content.

[Zireael07]

Request for improved UI was made in #59710

I am of two minds here - on the one hand, UI should not stop features but on the other, if people can't find features in a long list, they won't be used ... :(

[Drew4484]

Request for improved UI was made in #59710

I am of two minds here - on the one hand, UI should not stop features but on the other, if people can't find features in a long list, they won't be used ... :(

In particular this solves camps not being able to make the steels required for plate armor, which is a big pain in the ass for the player as that's a time consuming project.

[PatrikLundell]

If you were to remove the 200 pieces of armor and replaced it with this I would consider it to be a significant improvement, as it would cut down the list to just being cumbersome.

[I-am-Erk]

The order of operations folks are concerned about here is generally backwards. UI changes get pushed because the game exceeds our ability to handle UI, no changes ever happen if everything is working peachy.

[PatrikLundell]

Well, it's been an issue for a long time, so the despite it being unpeachy nobody has stepped up to fix it. I've failed to figure out how to do it.

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• A non-flamable mat used to protect surfaces from welding splatter or to insulate a weld when repairing tempered metal. This one is made with asbestos.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[I-am-Erk]

I am almost ready to merge, but what is the rationale and impact of adjusting the carbon steel stats? What things use these and will be changed?

[Drew4484]

I am almost ready to merge, but what is the rationale and impact of adjusting the carbon steel stats? What things use these and will be changed?

The goal of raising the numbers for carbon steels is based on conversations with some of the other armor contributors and feedback that the chainmail is underperforming. Raising the chainmail effectiveness means raising the carbon steel effectiveness as the two are integrated in the plate mail.

Items that will be impacted include the chain and plate mail of course, the combat exoskeletons, the vehicle hard steel plating, and the ballistic plate insert. The first two are deliberate, the combat exoskeletons are something I'd like to revisit the armoring of soon, the hard plating isn't very commonly used (from what I have seen) and the ballistic plate is underperforming on ballistics as it can't currently stop a 5.56 round. This does not fully resolve the ballistic plate issue but brings it closer to the stated NIJ level III.