Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Add a couple more mutant cats and improve cats in general

Open NetSysFire opened this issue 2 years ago • 6 comments

Summary

Content "More mutant cats"

Purpose of change

I felt like there should be more mutant cats, so I added some and also looked at cats in general. So I added two kinds of mutant cats (kittens included):

  • Liquid cats. The viscous kitten is inspired by https://nhqdb.alt.org/?1404
  • Void cats. These are black cats who regenerate in the dark.

And also normal black cats. These are all mostly cosmetic changes since cats are not intended to be a threat.

Describe the solution

I also did some general changes to pets:

  • Kitten scratch damage reduced to 1
  • Kittens are now also much smaller
  • Cats (except sphynx cats) have a natural cold armor of 2
  • Longhair cats have higher cold armor
  • Sphynx cats are now rarer in the wild, even irl this is a rather rare pet
  • Iridescent cats and kittens have a higher (+1) dodge chance than normal cats
  • I deduplicated some stuff and used copy-from instead because there was some redundancy.
  • Sphynx and Persian cats will die out eventually
  • Re-introduced the new monster groups for stray and pet animals.
  • Improved some descriptions.
  • Corrected the weight and volume of some cats.

I know the chonker is a meme but its description says it appears surprisingly well groomed (hint: feral cats in general are usually well groomed, only sick and old cats have problems with that) and it weighed a whopping 10 kg.

I volunteer in the local animal shelter to play and cuddle with the kitties (10/10, highly recommend donating time to your local shelter) and a couple of months ago they took in a cat which weighed 8 kg and already had severe problems grooming herself.

image

This is said cat at 8 kilograms. Luckily she was put on a diet immediately and was also adopted quickly due to her sweet personality, so this has a happy end.

8 kg is still much for the heckin' chonker but better than 10 kg.

Describe alternatives you've considered

We already have so many monsters, so I could have worked on the existing monsters instead of adding new ones.

Testing

Applied changes locally. Teleported and drove around the world to check the spawns. Looks fine to me. No cat world domination.

Additional context

I am obsessed with cats and especially kittens.

NetSysFire avatar Jul 09 '22 12:07 NetSysFire

Cats (except sphynx cats) have a natural cold armor of 2 Longhair cats have higher cold armor

~~Ice dogs confirmed 🙀?~~

TheShadowFerret avatar Jul 09 '22 16:07 TheShadowFerret

~~Ice dogs confirmed 🙀?~~

Dogs (and most animals with fur) could also use armor against cold, yes. The new elemental resistances are great but still need to be applied to more monsters. I will not touch dogs for now because I am unfamiliar with basically everything in the realm of dogs. I know their undercoat differs from cats and there may actually not be a big practical difference but this PR is about our feline overlords anyways.

Another sort-of irrelevant thing: The big chaos happened two weeks ago per lore yet suddenly all the pets have gone feral. I mean sure, if there are literal walking dead, which may even the former owners of a pet, who are attacking you as e.g a cat you will lose trust in humans quickly. However, cats are probably able to differentiate between zombies/ferals and normal humans due to their behavior. They can already mostly tell apart men from women as far as I know. This is not meant to start a discussion on this potentially sensitive topic but there are cats (even in the shelter I volunteer) who are generally scared of men due to being abused by cruel male members of society. The difference between zombies and normal humans is way more obvious.

If there is an interest in discussing this, it should be done in a separate issue if possible since this is a general lore complaint.

NetSysFire avatar Jul 09 '22 21:07 NetSysFire

While you're here another misc kitty fix would be using the new-ish nestable mongroups to replace the basic mon_cat wilderness spawns with the GROUP_STRAY_CATS mongroup to have the other breeds spawn outside of the cat person start/explicit mapgen spawns.

Venera3 avatar Jul 10 '22 10:07 Venera3

While you're here another misc kitty fix would be using the new-ish nestable mongroups

No idea about that honestly, I have not looked too much into monster spawns. However, I am planning to do a second PR where I fix that GROUP_PETS and GROUP_STRAY_CATS (plus GROUP_STRAY_DOGS) are not used where they should be. In this case animal pounds and pet shops are basically harcoded. If you give me a quick example about nestable mongroups I will look into this.

NetSysFire avatar Jul 10 '22 16:07 NetSysFire

The proper adjectives(Maine/German/Siamese) need to be re-cat(🥁)pitalized

TheShadowFerret avatar Jul 19 '22 02:07 TheShadowFerret

Alright. Done. I will do some more testing and after that I will mark it as ready to review.

NetSysFire avatar Aug 04 '22 16:08 NetSysFire