[Aftershock] Bounty hunter scenario

[Maleclypse]

Summary

Mods "Bounty Hunter Scenario for Aftershock"

Purpose of change

Adds a new scenario along with the associated first mission (tbd), a special starting map extra, terrain, furniture, monstergroup, eoc, and the c++ needed to power the eoc.

Describe the solution

Work in progress but once I realized I needed C++ I decided to go ahead and put this in draft to correct the errors that I'm sure will popup when CI tries to build this.

Describe alternatives you've considered

continuing to work on this without assistance

Testing

TBD

Additional context

[John-Candlebury]

Looks really nice. What do you think you'll need help with?

[Maleclypse]

Looks really nice. What do you think you'll need help with?

Right now I think I need to make an equivalent else statement for species_id as the follow for mytype_id

std::string spell::list_targeted_monster_names() const
{
    if( type->targeted_monster_ids.empty() ) {
        return "";
    }
    std::vector<std::string> all_valid_monster_names;
    for( const mtype_id &mon_id : type->targeted_monster_ids ) {
        all_valid_monster_names.emplace_back( mon_id->nname() );
    }
    //remove repeat names
    all_valid_monster_names.erase( std::unique( all_valid_monster_names.begin(),
                                   all_valid_monster_names.end() ), all_valid_monster_names.end() );
    std::string ret = enumerate_as_string( all_valid_monster_names );
    return ret;
}

[dseguin]

The c++ changes are a little more involved, so I made a PR against your fork with the fixes: https://github.com/Maleclypse/Cataclysm-DDA/pull/38

Hopefully it works first try this time :P

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• "Target Aquired."
• 3x35mm automatic 'Wandering Priest' coilpistols
• GG Splinter 3x35mm flechette
• GG Splinter 3x35mm flechettes
• GG Stinger 3x35mm flechette
• GG Stinger 3x35mm flechettes
• GG-860 Wasp Rifle
• GG-860 Wasp Rifles
• Iblis Interplanetary Drive
• Iblis Interplanetary Drive Console
• Iblis Interplanetary Navigation Console
• Scavbot Skorpion
• Scavbot Skorpions
• The Colaborator
• The Scavbot Skorpion is a refurb of colonial perimeter defense bots found across many systems. Because they are designed to defend against pirates, raiders, feral uplifts, hungry scavengers, rival mining clans, and any other enemy that is unlikely to attack with heavily armored units, these reprogrammed and refurbed versions are often found in the employ of the very types of people it was originally purposed to fight. Often found as the core of a light patrol or attack squad.
• This patch of hull has more holes in it than an ancient terran cheese. It may provide some cover or it might get shot through.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[Maleclypse]

@Procyonae I've done something backwards because I would think that these errors should be solved by each other?

(all_mods)=> (continued from above) ERROR : src/mapgen.cpp:482 [void mapgen_factory::check_consistency() const] Mapgen afs_bounty_hunter_gunship is not used by anything!
(all_mods)=> 23:22:16.855 ERROR : src/map_extras.cpp:2173 [map_extra_pointer MapExtras::get_function(const map_extra_id &)] no built-in map extra function with id mx_gunship
(all_mods)=> 23:22:16.855 ERROR : src/map_extras.cpp:2375 [void map_extra::check() const] invalid map extra function (mx_gunship) defined for map extra (mx_gunship)
(all_mods)=> 23:22:16.855 ERROR : src/map_extras.cpp:2173 [map_extra_pointer MapExtras::get_function(const map_extra_id &)] no built-in map extra function with id mx_truth_reconciliation
(all_mods)=> 23:22:16.855 ERROR : src/map_extras.cpp:2375 [void map_extra::check() const] invalid map extra function (mx_truth_reconciliation) defined for map extra (mx_truth_reconciliation)