http-science icon indicating copy to clipboard operation
http-science copied to clipboard

[WIP] Hash-based comparison for weak compare

Open ltclever opened this issue 9 years ago • 3 comments

an attempt to make weak compare faster

a little hacky. to be tested.

ltclever avatar Nov 01 '16 18:11 ltclever

cc @Christopher-Bradshaw @drhurd @samfishman

ltclever avatar Nov 01 '16 19:11 ltclever

ran a correctness job with weak compare enabled on permissions service (which sees array reordering)

standard recursive compare (master branch) results:

2016/11/01 20:10:02 Results map[int]map[int]int{},
2016/11/01 20:10:02 0 Diffs using weak compare: true,
{"control_url":"https://ltc--permissions-service.int.clever.com:443",
"deploy_env":"ltc-hs",
"diffs":0,
"exp_url":"https://ltc-exp--permissions-service.int.clever.com:443",
"last_gorfile":"/tmp/prod-replay-testing-permissions-service-1-2016-11-01-17-01-40-56f4d9d8-9654-458f-b178-89ff1c99818a.txt",
"level":"info",
"load_url":"",
"reqs":2122,
"source":"http-science",
"title":"progress"},
2016/11/01 20:10:02 2122 reqs in 35m14.470129024s seconds

ltclever avatar Nov 01 '16 20:11 ltclever

I've also found running it with some intentional diffs a useful sanity check.

Christopher-Bradshaw avatar Nov 01 '16 23:11 Christopher-Bradshaw