components icon indicating copy to clipboard operation
components copied to clipboard

include left and right border radius classes

Open prime-time opened this issue 8 years ago • 3 comments

Overview: We want to have a small border radius on just one side of a component, so I thought we may want to include new classes for this.

Screenshots/GIFs: screen shot 2018-02-02 at 3 31 12 pm We want a border radius on just the left of "This District" and on the right of the search bar. screen shot 2018-02-02 at 3 34 36 pm

Testing:

  • [ ] Unit tests
  • Manual tests:
    • [ ] Chrome
    • [ ] Safari
    • [ ] IE10

Roll Out:

  • Before merging:
    • [ ] Updated docs
    • [ ] Bumped version in package.json
      • Breaking change? Run npm version minor
      • Backward compatible change? Run npm version patch
      • Only changing documentation? All good. Skip this step.
  • After merging:
    • [ ] Deployed updated docs (make deploy-docs)

prime-time avatar Feb 02 '18 23:02 prime-time

https://github.com/Clever/components/blob/b31c95742bf4decaefbaac352f36dee1b0182ca8/src/less/border_radius.less#L3-L8

Seems like this file is auto generated, can you make changes to the script that generated it vs to the file directly?

cozmo avatar Feb 02 '18 23:02 cozmo

lol wops

prime-time avatar Feb 02 '18 23:02 prime-time

Thanks for the catch!

prime-time avatar Feb 02 '18 23:02 prime-time