bottom icon indicating copy to clipboard operation
bottom copied to clipboard

Allow for finer control over legend position/type

Open ClementTsang opened this issue 1 year ago • 9 comments

Checklist

Describe the feature request

For all time graphs, it would be nice to be able to have finer-grain control over how the legend is displayed (e.g. which side it appears, the type, like whether it's like the CPU one or normal ones, hiding it, etc).

ClementTsang avatar May 04 '23 04:05 ClementTsang

It would be useful to have the memory and network charts legends on the left too, maybe even by default, since right now it often happens you don't see anything until a few minutes after it happened because the chart lines are hidden by the legend.

RobertoMaurizzi avatar Sep 21 '23 14:09 RobertoMaurizzi

I'll add my request here since it seems more appropriate here than in a separate issue. I'd be nice to have an option to choose to show either the box of info in mem/net, over using the graph. Especially so if using a tiling wm such as I, and you've got a lot of windows open. That way when the window for btm gets shrunk I'd see the number like this 2023-11-23_12-48 rather than just seeing a graph which isn't all the useful when in small window.

JustCauseWhyNot avatar Nov 23 '23 19:11 JustCauseWhyNot

I completely agree this comment. So I make available that the chart can have a left legend at ratatui v0.25(https://github.com/ratatui-org/ratatui/pull/378).

It would be useful to have the memory and network charts legends on the left too, maybe even by default, since right now it often happen you don't see anything until a few minutes after it happens because the chart lines are hidden by the legend.

lyuha avatar Dec 25 '23 15:12 lyuha

I tested that chart draw a legend on left side. How about it?

Preview Images

image image

lyuha avatar Jan 04 '24 11:01 lyuha

I'd say it's definitely more useful, thanks @lyuha!

RobertoMaurizzi avatar Jan 08 '24 01:01 RobertoMaurizzi

I read the refactoring commit(77777ef5887c2e1bd1a10c55cbb329c0471d4388). Now the TimeChart has an option to configure it's legend position. However, Bottom doesn't have any config option about a legend position.

Is there any plan about this? Add options like cpu's left_side in config file, add key layout section in config? or have any other?

lyuha avatar Feb 21 '24 00:02 lyuha

Yep, was planning on adding this at some point.

ClementTsang avatar Feb 21 '24 01:02 ClementTsang

Is there anything that I help this work?

lyuha avatar Feb 21 '24 10:02 lyuha

If you want you can try to make a PR, but it's mostly figuring out how the config/arg option would look really.

ClementTsang avatar Feb 21 '24 19:02 ClementTsang