ClemBot icon indicating copy to clipboard operation
ClemBot copied to clipboard

Bug: Trashcan Emoji Does Not Timeout for Several Commands

Open Exper1mental opened this issue 3 years ago • 1 comments

I noticed the other day that several of ClemBot's commands appear to have no trashcan emoji timeout, meaning that anytime in the future the command query author can click the trashcan for ClemBot to delete the message. Specifically, I noticed that an !info command message I had sent half a day before still had the trashcan, and when pressed still deleted the message.

If I understand correctly, this also means that ClemBot is basically creating and storing an ever-growing list of messages in the self.messages array of delete_message_service.py until the bot crashes or restarts.

Commands confirmed to have the issue

  • info

Commands suspected to have the issue

  • source list (source <file-name> works just fine)
  • tags
  • help
  • define (but not define error messages)
  • grades (specifically grades <course-ID> haven't checked others)
  • convert / bconvert error messages
  • prof list
  • roles
  • ClemBot error messages (e.g. command not found)

Commands that do not have the issue

  • slots
  • ogslots
  • translate
  • define error messages
  • convert / bconvert
  • source print

Anything not listed hasn't been checked by me.

By suspected, I mean that I haven't tried pressing the trashcan on the output from one of these commands to confirm ClemBot will still delete the message.

Example

image

Exper1mental avatar Mar 27 '22 13:03 Exper1mental

The info command doesn't have a set timeout, it will last for as long as the bot hasn't restarted, adding a timeout is trivial if we want to do that

Jay-Madden avatar Mar 27 '22 14:03 Jay-Madden

Could I be added to this issue? And clarifying question, would you prefer adding a default timeout value or adding a timeout value to each of the services which do not have it?

arock475 avatar Dec 02 '23 16:12 arock475