Claire

Results 1010 comments of Claire

> > I'd remove the extra `current = @current_user` lines, and I'd also rename `sensitive_user_data` to `view_sensitive_user_data`. > > The admin REST API also needs to be changed, as the...

Hi! You haven't taken last week's requests for changes into account yet!

I think it would indeed be much simpler to just have the `domain` from the `initial_state` contain the unicode representation.

I think `domain` here is pretty much used only for display purposes, though. But I may be wrong, I'd have to double-check.

> Is any defence against homonym attacks needed here? Do we run the risk of fake Mastodon instance impersonating real ones using indistinguishable unicode charts? I'd say we do not...

> I removed the unneccesary ones, per @ClearlyClaire. I still think this is the way to go, to render the domain when it's rendered. But I can change it so...

> Alright, much simpler now! Thanks again for the PR! > (sorry for the all the pushes, my git got into some weird state there for a second). No worries!

@Sasha-Sorokin the library we use is https://react-bootstrap.github.io/react-overlays/api/Overlay, it does seem to use Popper.js, and we control the CSS, but the library's code seem to assume absolute positioning and just switching...

@Sasha-Sorokin indeed, we're using a severely outdated version… I'm not sure newer versions allow us to use `position: fixed` though, and I tried using the latest version, but couldn't get...

@Sasha-Sorokin sure, I did try to account for the API changes (for the status dropdown at least, trying to get those to work first), but the injected style positions the...