fix issue #656: add 'modules' keyword arg to load Redis extension modules

[mguijarr]

Here is a pull request to close #656 , taking into account comments in : https://github.com/ClearcodeHQ/pytest-redis/pull/657

(sorry had to create a new pull request... Not super at ease with github vs gitlab !)

[fizyk]

@mguijarr one last thing.... would you be able to add some tests as well?

[fizyk]

Oh, one last thing, please mention in the documentation that it will not work for noproc fixtures.

[mguijarr]

@mguijarr one last thing.... would you be able to add some tests as well?

I added a test, just for modules keyword argument (didn't find the tests for pytest.ini and pytest command line args)

[mguijarr]

Oh, one last thing, please mention in the documentation that it will not work for noproc fixtures.

I thought it was done already ? In the table, it has - for noproc-fixture column

[fizyk]

I thought it was done already ? In the table, it has - for noproc-fixture column

Yeah, the column lists configuration for the fixture if you'd want to use the fixture factory, and pass your own values there. There's nothing else stating that if you configure from command line or config file, it will not affect the redis connected to through noproc fixture.

[mguijarr]

I thought it was done already ? In the table, it has - for noproc-fixture column

Yeah, the column lists configuration for the fixture if you'd want to use the fixture factory, and pass your own values there. There's nothing else stating that if you configure from command line or config file, it will not affect the redis connected to through noproc fixture.

I just added more descriptive documentation

[fizyk]

@mguijarr now, there are some issues with mypy now and the ruff linter left :)

[mguijarr]

Sorry for the long delay, have been busy - ok I tried to make mypy happy and I applied ruff

[mguijarr]

Ok thanks for approval to let tests pass.. Again it fails with mypy 😭

No idea what is wrong

[mguijarr]

I don't use mypy maybe you can make the fix yourself ? If you don't mind

[fizyk]

I'll try to take a look sometimes next week :)

[mguijarr]

Looks nice 🥳 Is it ready to merge soon?

[mguijarr]

Thanks a lot! 👍🏻 And a great thank you for pytest-redis, very useful

[fizyk]

Thank you for your contribution :)

Wait a bit, till I add python 3.12 proper support, and redis 7.2 into tests and I'll be releasing new version :)