ClearcodeHQ
add support for `\` character in pytest temporary path - Closes #982
Description
add support for \ character in pytest temporary path - Closes #982
Testing:
You can see I have broken the PR into two commits.
In the first commit the new test fails on a "good" machine (XFAIL):
The second commit adds the fix. The tests PASSED on both "good" and "bad" machines:
Chore
Chore that needs to be done:
- [ ] Add newsfragment
pipenv run towncrier create [issue_number].[type].rst
P.S.
I noticed flake8 is failing in the pre-commit hook. I'll assume I should be using ruff now and the hook is just out of date..
🤔 pre-comit-config hasn't been updated in years, don't mind it for the time being. It should be addressed separately
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.83%. Comparing base (
22944af) to head (a24d7dc). Report is 233 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 95.26% 95.83% +0.57%
==========================================
Files 13 13
Lines 401 432 +31
==========================================
+ Hits 382 414 +32
+ Misses 19 18 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 95.83% <100.00%> (+0.57%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I have rebased this change on top of our other recent updates.
The test confirms the path can contain backslashes, "\", as well as spaces, " ".