Addon icon indicating copy to clipboard operation
Addon copied to clipboard

add exclusion setting for domains ( related issue #353 )

Open KMohZaid opened this issue 1 year ago • 10 comments

Problem in this PR is : I am "noob" and i don't know how to use i18n translation . so we have to do it.

KMohZaid avatar Sep 19 '24 14:09 KMohZaid

related issue : https://github.com/ClearURLs/Addon/issues/353

(wow sonarcloud, i didnt know they have this intregation for free)

KMohZaid avatar Sep 19 '24 14:09 KMohZaid

lol, i knew i should do something to keep 1 return url statement but lazy to do and it was feeling complex if i does

and sad, i forgot to remove test console.log

KMohZaid avatar Sep 19 '24 14:09 KMohZaid

image preview

KMohZaid avatar Sep 19 '24 14:09 KMohZaid

@KMohZaid +1 to have this merged in and released. I would love to finally have this feature in ClearURLs. It would make my life so much better.

Beagle avatar Sep 30 '24 16:09 Beagle

Lol I didn't notice a mistake

In regex explanation, after m there was ? which i think i accidentally removed

KMohZaid avatar Oct 04 '24 11:10 KMohZaid

Quality Gate Passed Quality Gate passed

Issues 5 New issues 0 Accepted issues

Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarCloud

fix: 5 issues reported by sonarcloud 4e31424

(https://github.com/ClearURLs/Addon/pull/383#issuecomment-2402006872)

  1. using variable to store boolean and if any boolean is true, then return url
  2. using for-of for list
  3. we are using "storage" variable to store dictionary data not array, so made it "{}" from "[]"
  4. "value" parameter in setData was string when case was "excludeDomains", still removed its console.log (not needed to console log it now so)

KMohZaid avatar Oct 09 '24 11:10 KMohZaid

This PR is a feature to solves the #387 issue.

tcelestino avatar Dec 11 '24 13:12 tcelestino

This PR is a feature to solves the #387 issue.

No, this is just workaround. I think we should check what are tracking parameters for Google sheets domain and add rules for them. This feature will trust domain and allows unfiltered url loading

KMohZaid avatar Dec 17 '24 06:12 KMohZaid

@KMohZaid: Can you create a PR on Gitlab too?

  • https://gitlab.com/ClearURLs

If it is not merged, I think it is the moment to fork this project.

Linked to:

  • https://github.com/ClearURLs/Addon/pull/372

Neustradamus avatar Aug 02 '25 07:08 Neustradamus