Addon
Addon copied to clipboard
add exclusion setting for domains ( related issue #353 )
Problem in this PR is : I am "noob" and i don't know how to use i18n translation . so we have to do it.
related issue : https://github.com/ClearURLs/Addon/issues/353
(wow sonarcloud, i didnt know they have this intregation for free)
lol, i knew i should do something to keep 1 return url statement but lazy to do and it was feeling complex if i does
and sad, i forgot to remove test console.log
preview
@KMohZaid +1 to have this merged in and released. I would love to finally have this feature in ClearURLs. It would make my life so much better.
Lol I didn't notice a mistake
In regex explanation, after m there was ? which i think i accidentally removed
Quality Gate passed
Issues
5 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
fix: 5 issues reported by sonarcloud 4e31424
(https://github.com/ClearURLs/Addon/pull/383#issuecomment-2402006872)
- using variable to store boolean and if any boolean is true, then return url
- using for-of for list
- we are using "storage" variable to store dictionary data not array, so made it "{}" from "[]"
- "value" parameter in setData was string when case was "excludeDomains", still removed its console.log (not needed to console log it now so)
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
nice
This PR is a feature to solves the #387 issue.
This PR is a feature to solves the #387 issue.
No, this is just workaround. I think we should check what are tracking parameters for Google sheets domain and add rules for them. This feature will trust domain and allows unfiltered url loading
@KMohZaid: Can you create a PR on Gitlab too?
- https://gitlab.com/ClearURLs
If it is not merged, I think it is the moment to fork this project.
Linked to:
- https://github.com/ClearURLs/Addon/pull/372