Cleanroom icon indicating copy to clipboard operation
Cleanroom copied to clipboard

Sort plugin before loading, giving users more freedom in file names

Open Ecdcaeb opened this issue 3 months ago • 6 comments

Before : image

After : image

Ecdcaeb avatar Oct 01 '25 07:10 Ecdcaeb

Hmmmm, you know... Sorting does not exist if everyone try to be the first

KorewaLidesu avatar Oct 01 '25 10:10 KorewaLidesu

Hmmmm, you know... Sorting does not exist if everyone try to be the first

That's indeed exaggerated: it's not about making mods use the "!" symbol, but rather about solving the issue of loading order changes caused by mod naming. In fact, some users, particularly those in China, often translate mods into Chinese, which disrupts the file order and frequently results in the loss of the "!" symbol. This PR provides a sorting mechanism that prioritizes mod relationships over file names. The goal is to ensure consistent ordering across different naming conventions as satisfactorily as possible.

Ecdcaeb avatar Oct 01 '25 10:10 Ecdcaeb

Just write it like ![prefix]translated name So here's why this is useless:

  1. The reason of 99% of coremods being coremods is, transforming. This come in two ways: ASM and Mixin.
  2. You don't need dependency in ASM.
  3. As for Mixin, I don't want to encourage Mixin into other coremods, and CleanMix won't need target class appeared to load mixins.
  4. The main reason of class not found in coremod is mixin provider not loaded. But our Mixin comes with the loader. Next version will support FermiumBooter API too.

kappa-maintainer avatar Oct 01 '25 11:10 kappa-maintainer

Just write it like So here's why this is useless:![prefix]translated name

  1. The reason of 99% of coremods being coremods is, transforming. This come in two ways: ASM and Mixin.
  2. You don't need dependency in ASM.
  3. As for Mixin, I don't want to encourage Mixin into other coremods, and CleanMix won't need target class appeared to load mixins.
  4. The main reason of class not found in coremod is mixin provider not loaded. But our Mixin comes with the loader. Next version will support FermiumBooter API too.

This is indeed unnecessary. Because when players encounter such issues, we only need to point them out. Renaming the files or adopting your suggested approach, such as placing the "!" symbol at the beginning, are both effective methods. When problems arise, we can resolve them easily and consistently communicate the solutions to the players. However, in reality, I hope to add this feature to address the issue, even though it is a very minor improvement. Of course, you can raise questions, such as whether it compromises compatibility, and we can continue to discuss it.

Ecdcaeb avatar Oct 01 '25 11:10 Ecdcaeb

I do want to merge this commit. But with the race between each coremod try to take over sorting order, the sorting will only really work if no one re-inventing another way to do something same and make everyone else suffering from it. So for now this should be in the bin, but if we can come with the term later may this commit merge.

KorewaLidesu avatar Oct 01 '25 12:10 KorewaLidesu

  • I don't think this feature is necessary in future Cleanroom, and we don't add an API that nobody use.
  • I don't want to add too many features to coremod and encourage ppl to make more coremod. ASM should never be a proper way to develop mods.

kappa-maintainer avatar Oct 01 '25 12:10 kappa-maintainer