Cleanroom icon indicating copy to clipboard operation
Cleanroom copied to clipboard

Enable NetworkCheckerHandler to use updated String methods

Open Ecdcaeb opened this issue 6 months ago • 4 comments

The old method returned a boolean, and as you can see, its internal method has been deprecated. boolean check(Map, Side) -> String checkCompatible(Map, Side) The new method returns a String, which means that custom incompatibility information can be provided.

This PR just turns on this feature, and does not add anything.

In fact, this method was originally inaccessible (this deprecation is meaningless(x

Ecdcaeb avatar Jun 19 '25 16:06 Ecdcaeb

What's the purpose of this I can't find new features in your comments

kappa-maintainer avatar Jun 20 '25 02:06 kappa-maintainer

What's the purpose of this I can't find new features in your comments

The old method returned a boolean, and as you can see, its internal method has been deprecated. boolean check(Map, Side) -> String checkCompatible(Map, Side) The new method returns a String, which means that custom incompatibility information can be provided.

This PR just turns on this feature, and does not add anything.

In fact, this method was originally inaccessible (this deprecation is meaningless(x

Ecdcaeb avatar Jun 20 '25 02:06 Ecdcaeb

Should mention that in comment Also, many deprecations were meant to be removed in 1.13, which do not apply here

kappa-maintainer avatar Jun 20 '25 02:06 kappa-maintainer

Should mention that in comment

kappa-maintainer avatar Aug 05 '25 03:08 kappa-maintainer