Cleanroom icon indicating copy to clipboard operation
Cleanroom copied to clipboard
verified publisher icon CleanroomMC

Use MCP mappings for in-repo patches

Open Ecdcaeb opened this issue 2 years ago • 3 comments

LexManos use official mappings for in-repo patches, will be converted to SRG during build. Should we do the same things? https://github.com/MinecraftForge/MinecraftForge/commit/40a799828190bee2d817f2f9154edadceda44ddc

Ecdcaeb avatar Jan 06 '24 14:01 Ecdcaeb

Since we're on a non-competing version of mappings, we might even switch to mcp names even at runtime in the future.

I welcome this kind of change, we should use mcp wherever possible.

Rongmario avatar Jan 06 '24 14:01 Rongmario

Ah, LexManos uses runtime-offical in new Forge.

Ecdcaeb avatar May 11 '24 10:05 Ecdcaeb

In the newest 1.20.4+ I believe, yes.

Rongmario avatar May 11 '24 11:05 Rongmario