CleanroomMC
Better controls option menu
Please provide more details about this PR, e.g. API changes, what have been tested, screenshots.
And honestly, I dont think this is necessary. Controlling is doing pretty good in terms of Cleanroom compatibility, integrating it directly (without adding features) is not any better than installing an individual mod.
Okay, so the port reason is this project item.
I hope I'm not misunderstanding.
the first sentence is includes better UI so I made this port.
About the API changes:
I violently copied the Controlling code straight over.
Unlike installing Controlling directly, I modified the vanilla GUI directly in Forge Patches.
This means that if any other mod modifies the GuiControls class or the GuiKeyBindingList class using Mixin or the like, there will be predictable problems.
And I also directly changed the type of one of the member variables, and while it was private protected and I fixed most of the calls associated with it, there's no guarantee that other mods will call that variable elsewhere.
I will be fix this problem later.
About tested:
It can work like origin Controlling, and I add some language support (btw it is less than original).
I am sorry I am not working on my PC now so I will put some screenshots later.
And honestly, I dont think include Controlling is a good idea but I think we need a better controls menu.