Cleanroom icon indicating copy to clipboard operation
Cleanroom copied to clipboard

Include FastFurnace mod (features).

Open Oganesson897 opened this issue 1 year ago • 7 comments

Summary

Included the FastFurnace mod. Not FastWorkbench.

Oganesson897 avatar Jul 25 '24 07:07 Oganesson897

Fast Furnace is superseded by UT. There's no need to bundle it in

Oregano1963 avatar Jul 26 '24 02:07 Oregano1963

Moving fixes for vanilla directly into Cleanroom is one of our goal The only problem is, will this PR crash UT's mixin?

kappa-maintainer avatar Jul 26 '24 03:07 kappa-maintainer

Fast Furnace is superseded by UT. There's no need to bundle it in

I don't think this is true, UT caches crafting recipes only (so that's FastWorkbench functionality?). If I remember correctly, CensoredASM is the one that supersedes FastFurnace, and it mixins into FurnaceRecipes, not TileEntityFurnace. You might want to check Rong's impl in CASM if it's better than FastFurnace and use that.

jchung01 avatar Jul 26 '24 03:07 jchung01

FastFurnace replaced the furnace block, and it will be override the createNewTileEntity function to creat the faster furnace tile entity.

so run the game with FF is safety.
I searched furnace keywords in UT's curse page, but not found any info of FastFurnace Included.

I have not checked the code of CASM or UT. btw i merged the TileFastFurnace class into vanila furnace tile code, not more.

Oganesson897 avatar Jul 26 '24 05:07 Oganesson897

I tested the compability this feature with UT or FastFurnace. Not crash and furnace is workable.

Oganesson897 avatar Jul 30 '24 00:07 Oganesson897

It's better to use loliasm's implementation than fastfurnace's.

Rongmario avatar Aug 08 '24 23:08 Rongmario

It's better to use loliasm's implementation than fastfurnace's.

Ok

Oganesson897 avatar Aug 10 '24 16:08 Oganesson897