Cleanroom icon indicating copy to clipboard operation
Cleanroom copied to clipboard

Imple JAXB with `org.glassfish.jaxb` and Install it

Open Ecdcaeb opened this issue 1 year ago • 0 comments

Summary

Cleanroom has got jakarta xml and transformered the reference of javax.xml for a long time. But the implement, org.glassfish.jaxb, was not downloaded. It means such a Exception will be thrown:

Caused by: jakarta.xml.bind.JAXBException: Implementation of Jakarta XML Binding-API has not been found on module path or classpath.
 - with linked exception:
[java.lang.ClassNotFoundException: org.glassfish.jaxb.runtime.v2.ContextFactory]
	at jakarta.xml.bind.ContextFinder.newInstance(ContextFinder.java:250)

I found that the client/server did not download JAXB libraries.

Changes

Install org.glassfish.jaxb and it's dependencies.

Relates

Fix #109 .

Test

ModPack https://github.com/Ecdcaeb/ecdcaeb/raw/main/disk/bin/minecraft/Cleanroom%23109.zip Running successfully with Forge 2860. Crash with cleanroom at 26, 27, 28, 29 and so on... Running successfully with This PR

Ecdcaeb avatar Apr 12 '24 08:04 Ecdcaeb