nvml-wrapper icon indicating copy to clipboard operation
nvml-wrapper copied to clipboard

Provide idiomatic abstraction for vGPU type information

Open christoph-heiss opened this issue 1 year ago • 3 comments

Pretty straight forward overall. Introduces a new VgpuType struct, which wraps over a nvmlVgpuTypeId_t and a proper idiomatic way to access these informations.

I'v also added a Nvml::lib() method, for accessing the underlying (raw) library from the abstraction. This would be useful for e.g. calling functions which are not yet abstracted in nvml-wrapper, without having to completely use nvml-wrapper-sys and NIH, basically. Hopefully that is acceptable.

christoph-heiss avatar Nov 06 '24 11:11 christoph-heiss

Ping. Is this of any interest for this library?

christoph-heiss avatar Apr 10 '25 17:04 christoph-heiss

@christoph-heiss Thanks for the ping. A bit of background is that we (IOP Systems) became the primary maintainer of this repo earlier this year, after the original owner took a job that made it tricky for them to contribute to OSS. This PR was submitted before we came on board, and fell through the crack a bit during this transition. We will take a look and hopefully get it merged soon.

thinkingfish avatar Apr 11 '25 04:04 thinkingfish

Thanks for the review! I've fixed both nits.

christoph-heiss avatar Apr 24 '25 08:04 christoph-heiss

I'm gonna go ahead and merge this as it's been a few months and the code LGTM. Thanks for the PR!

swlynch99 avatar Jun 10 '25 00:06 swlynch99