ER-Save-Editor icon indicating copy to clipboard operation
ER-Save-Editor copied to clipboard

Caria Manor regions marked as incomplete

Open dinhani opened this issue 1 year ago • 4 comments

These 3 regions are sharing the same ID when the HashMap is being created.

"Caria Manor" and "Main Caria Manor Gate" are marked as incomplete, probably because they are being overwritten in the HashMap.

https://github.com/ClayAmore/ER-Save-Editor/blob/60411777a422e12cd1d43df080e2b024a151c3c7/src/db/regions.rs#L489-L491

dinhani avatar Mar 30 '24 22:03 dinhani

Hey dinhani. Thanks for the feedback.

The keys to this hashmap is the enum so it's alright that multiple regions share the same ID since it's part of the value not the key. Also these are only the invadeable regions and the feature is meant to be used for turning on or off invasion spots. I probably should make that more clear.

What do you mean by it's marked as incomplete? How does it look in the game I mean?

ClayAmore avatar Mar 30 '24 23:03 ClayAmore

By incomplete I mean they appear unchecked in the tool interface. These are the only two scenarios where this is happening.

To clarify things further, I was using this tool to check if I missed something in my progress and not to edit saves.

The in-game map seems to have everything unlocked according to a few reference maps I found online.

Sorry about the confusion with HashMap, you are correct the ID is not the key. But it seems odd that these are the only regions that have the same ID for multiple entries? I did not spot other regions where the same ID is assigned to more than one region.

Tool

tool

In-game map

caria-manor-region

dinhani avatar Mar 31 '24 08:03 dinhani

Actually I posted the wrong link pointing to the possible HashMap issue.

This is the correct one: https://github.com/ClayAmore/ER-Save-Editor/blob/60411777a422e12cd1d43df080e2b024a151c3c7/src/db/regions.rs#L267-L269

Here the ID is being used as the key of the HashMap.

dinhani avatar Mar 31 '24 08:03 dinhani

I see. Those indeed seem like the wrong values. I'll fix that on the next release. Thanks for the feedback.

ClayAmore avatar Mar 31 '24 15:03 ClayAmore