Claus Klein

Results 179 comments of Claus Klein

the sandbox source tree was checked with this clang-tidy config file: https://github.com/ClausKlein/cereal/blob/develop/.clang-tidy ```shell Claus-iMac:cereal clausklein$ make -n run-clang-tidy mkdir -p ../.build-cereal-Debug cd ../.build-cereal-Debug && cmake -G Ninja -Wdeprecated -Wdev \...

I did not know that I can easily extend the `settings.yml`. The `conanfile.py `of **zlib** or **crypto** lib is as it is. And `autoconf` does not work with **GHS** toolchain....

Yes, it seems so ... ------------------- ``` MSYS ~/workspace/cpp/example_conan_flow $ !conan conan create . conan/stable --build=missing msys Hello/1.1@conan/stable: Exporting package recipe Hello/1.1@conan/stable: The stored package has not changed Hello/1.1@conan/stable (test...

The clang-tidy toolchain used has an different version! ```bash bash-3.2$ /usr/local/opt/llvm/bin/clang-tidy -version Homebrew LLVM version 13.0.0 Optimized build. Default target: x86_64-apple-darwin21.4.0 Host CPU: skylake bash-3.2$ ```

> Is this a clang-tidy bug? I think not. There are often problems with `clang-tidy` or `include-what-you-use` when the compiler is `g++` or `apple-clang++`. I prevented this by disabling **PCH**...

``` -- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include -- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include/greeter -- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include/greeter/greeter.h ``` And this info in not right: ```bash cat: /Users/clausklein/Workspace/cpp/stage/usr/share/greeter/usage find_package(greeter CONFIG REQUIRED) target_link_libraries(main PRIVATE greeter::greeter greeter::project_options greeter::project_warnings) ``` see...

> It seems correct to me. I don't see any issue here. Yes, "seems" it is correct, but may be prevented to be clear. It looks strange in context of...

The correct usage message should: ```cmake find_package(greeter CONFIG REQUIRED) target_link_libraries(main PRIVATE greeter::greeter) ```

> The correct usage message should: > > ```cmake > find_package(greeter CONFIG REQUIRED) > target_link_libraries(main PRIVATE greeter::greeter) > ``` This links `fmt::fmt;greeter::project_warnings;greeter::project_options` implicitly.

NOTE: with `ENABLE_INTERPROCEDURAL_OPTIMIZATION` it fails on on **CI macOS-11 llvm**! see https://github.com/aminya/project_options/runs/5640388101?check_suite_focus=true On my iMac with `AppleClang 13.1.6` it builds without errors: ```bash task: [clean] rm -rf ./test/build ./test_install/build task:...