Obfuscapk icon indicating copy to clipboard operation
Obfuscapk copied to clipboard

ResStringEncryption improvement

Open Elyorbe opened this issue 5 years ago • 1 comments

Hi, I tested sample apk with ResStringEncryption option. It works with only resource strings which are read using String type. If StringBuilder or StringBuffer type used for reading, resource string is ignored.

Proposed solution

Add StringBuilder and StringBuffer checking for ResStringEncryption obfuscator

Additional context

Ljava/lang/StringBuilder and Ljava/lang/StringBuffer options can be added for regex pattern checking https://github.com/ClaudiuGeorgiu/Obfuscapk/blob/c9e493b6b6656f58a46108101432064b93874056/src/obfuscapk/obfuscators/res_string_encryption/res_string_encryption.py#L104-L118

Would you like to submit a pull request for this feature?

Yes

Elyorbe avatar Jul 29 '20 03:07 Elyorbe

Hi @Elyorbe, thanks for your interest in this project. I'll be happy to review your PR :+1:

ClaudiuGeorgiu avatar Jul 30 '20 09:07 ClaudiuGeorgiu