FactoryPlanner icon indicating copy to clipboard operation
FactoryPlanner copied to clipboard

crash while removing modules

Open burninghey opened this issue 10 months ago • 4 comments

Problem Description

Crash;:

Die Mod Factory Planner (1.1.78) hat einen Fehler verursacht, der nicht behoben werden kann. Bitte informiere den Autor der Mod über diesen Fehler.

Error while running event factoryplanner::on_gui_click (ID 1) factoryplanner/ui/main/production_handler.lua:168: attempt to index field 'parent' (a nil value) stack traceback: factoryplanner/ui/main/production_handler.lua:168: in function 'handler' factoryplanner/ui/event_handler.lua:157: in function <factoryplanner/ui/event_handler.lua:114>

Reproduction

plan something with modules and beacons remove modules remove modules in beacons / remove beacons with right click

I planned to build some mod item (nuclear artillery). While trying to put modules on (vanilla) ingredients, and removing, it crashed reproducable

burninghey avatar Apr 03 '24 20:04 burninghey

Not sure when exactly the crash happens. I'm editing the speed modules in beacons. Removing them, adding them again, sometimes crash happens on rightclick the speed module (last row)

image

burninghey avatar Apr 03 '24 20:04 burninghey

maybe related to https://github.com/ClaudeMetz/FactoryPlanner/issues/271

burninghey avatar Apr 03 '24 20:04 burninghey

Not sure when exactly the crash happens.

A 100% reliable way to reproduce:

  • Have a recipe with a module, e.g. productivity
  • Right click the module to open the module dialog
  • Right click in the dialog to remove the module
  • Close the dialog with ESC
  • The module is still displayed in the overview. Right clicking it again causes above error

Scarabytes avatar May 08 '24 08:05 Scarabytes

A 100% reliable way to reproduce

I've had the same bug (on beacon modules) and can confirm the repro steps. It doesn't have to be closed using ESC, pressing Cancel also triggers the issue.

Edit: seems like a duplicate of #263

Zeroji avatar May 26 '24 08:05 Zeroji