FactoryPlanner icon indicating copy to clipboard operation
FactoryPlanner copied to clipboard

SE Matter Fabs can have beacons copied to them and end up showing wrong quantities.

Open Vovosunt opened this issue 2 years ago • 2 comments

You can't set modules or beacons for Space Exploration Matter Fabricators, but you CAN copy beacons from the rest of the factory and paste them onto matter fabricators. This results in planner showing wrong "beaconed" calculations.

Vovosunt avatar Nov 18 '23 00:11 Vovosunt

Hm that's a weird one, the mod thinks the fabricators can accept beacons. I'll have to look into what's going on there. Thanks for letting me know. (Material Fabricators can produce Naquium Cubes, Antimatter, Matter Fusion, Matter Synthesis Data.)

Edit: Oh actually, there's two issues here. First, the mod allows beacons for the fabricator, but you can't add any modules, in which case it should just not allow it in the first place. Second, it apparently allows pasting beacons with incompatible modules, which is also wrong. I'll look into both things, thank you!

(Also, apparently there are some mods that have beacons without modules still affect things (Py's potentially), so that's a headache and a half)

ClaudeMetz avatar Nov 19 '23 13:11 ClaudeMetz

I fixed being able to paste beacons that have only incompatible modules for the next release, thanks for the report.

The SE issue is a bit different. It will now not allow you to paste anything invalid onto it anymore, but it'll still show the ability to add beacons, even though you can't add any modules. This is not quite so simple to fix, because figuring out when to show this is quite complicated, and depends on recipe and machine as well. Running that code on each refresh is a bit much, performance-wise, so I'd have to cache the result, and refresh that cache on any change. I'll have to think about it some more. Either way though, any invalid configurations shouldn't be possible anymore now.

ClaudeMetz avatar Dec 09 '23 14:12 ClaudeMetz