FactoryPlanner icon indicating copy to clipboard operation
FactoryPlanner copied to clipboard

Support fluid burners that produce steam.

Open falsedrow opened this issue 1 year ago • 6 comments

Specifically, py's Oil Burner MK 01.

falsedrow avatar Oct 30 '23 16:10 falsedrow

Err, don't think it works like that. This might add the entities, but it doesn't use them properly to calculate stuff, and more.

ClaudeMetz avatar Nov 15 '23 15:11 ClaudeMetz

Can you give me an example of what wouldn't work? There's already support for fluid burners in generate_category_entry.

falsedrow avatar Nov 17 '23 02:11 falsedrow

Hm maybe I spoke too soon, I'll look into the details at some point then.

ClaudeMetz avatar Nov 17 '23 18:11 ClaudeMetz

Funny, I ran into this issue as well, modified my local generator.lua in the same way (minus the line end..) and after seeing it work in Pyanodons, I came here to find that there was already this PR 😄

If it means anything, this code looks good to me, and works well in Py at least. 👍 from me!

image

ljgw avatar Feb 21 '24 15:02 ljgw

@ClaudeMetz did the same thing as OP and @ljgw, and then found this PR it works as expected for the py Oil Burner

Ifry avatar Jul 24 '24 22:07 Ifry

Yeah I'll have to have another look at this.

ClaudeMetz avatar Jul 25 '24 09:07 ClaudeMetz