Classiq
Adapt VQE- Paper Implementation Challenge
This pull request is related with this project: https://github.com/Classiq/classiq-library/issues/798. Here it is the ideas we have:
- We make and Adapt-VQE code using Qiskit-Nature, tested for H-H, H-Li, and H-F.
- We look for changes to the original VQE code of Classiq, trying to understand what kind of changes must be done to make the Adapt-VQE (basically, add flexibility to the algorithm).
- We study all the source code (to reach the quality standard you need) and the best idea we believe than we can implement is to make the code flexible following the idea of the flexible QPE example.
We require some time to complete the code combination and test at least with the 3 examples mentioned before. It will be made more changes in this request.
Check out this pull request on 
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
![review-notebook-app[bot] avatar](https://avatars.githubusercontent.com/in/15474?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @Dacastillo , it is unclear what this PR is for. You added two notebooks, that seem very similar to ones we already have. In addition, you added some qiskit-nature code. I do not see how this PR addresses issue for Adaptive VQE.
I am not sure how the approach of flexible_qpe is relevant here. Feel free to reach out to the community on Slack if you have questions.
We can extend the deadline, how much time do you think you need to complete your contribution?
Dear Tomer: This code is clearly not a complete result. We are working on having a code that satisfies the project. The notebook we put are the basis we are using to understand the Classiq code and translating the Qiskit-Nature made code to something the Classiq system can work in. I talked with Tali Cohn and we received a new deadline (until this Sunday) to make the implementation visible for you. We will make all for respecting this new date.
Any advice you can give us for the translation will be helpful. We can doing all the queries needen on the Slack channel.
Greetings.
De: TomerGoldfriend @.> Enviado: martes, 1 de abril de 2025 5:09 Para: Classiq/classiq-library @.> Cc: Daniel Andres Castillo Castro @.>; Mention @.> Asunto: Re: [Classiq/classiq-library] Adapt VQE- Paper Implementation Challenge (PR #899)
No suele recibir correo electrónico de @.*** Por qué es esto importantehttps://aka.ms/LearnAboutSenderIdentification
Hi @Dacastillohttps://github.com/Dacastillo , it is unclear what this PR is for. You added two notebooks, that seem very similar to ones we already have. In addition, you added some qiskit-nature code. I do not see how this PR addresses issuehttps://github.com/Classiq/classiq-library/issues/798 for Adaptive VQE.
I am not sure how the approach of flexible_qpe is relevant here. Feel free to reach out to the community on Slack if you have questions.
We can extend the deadline, how much time do you think you need to complete your contribution?
— Reply to this email directly, view it on GitHubhttps://github.com/Classiq/classiq-library/pull/899#issuecomment-2768538930, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVDV34BA6BXVXK4CS74VD32XJCUXAVCNFSM6AAAAABZ6N7DOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRYGUZTQOJTGA. You are receiving this because you were mentioned.Message ID: @.***>
[TomerGoldfriend]TomerGoldfriend left a comment (Classiq/classiq-library#899)https://github.com/Classiq/classiq-library/pull/899#issuecomment-2768538930
Hi @Dacastillohttps://github.com/Dacastillo , it is unclear what this PR is for. You added two notebooks, that seem very similar to ones we already have. In addition, you added some qiskit-nature code. I do not see how this PR addresses issuehttps://github.com/Classiq/classiq-library/issues/798 for Adaptive VQE.
I am not sure how the approach of flexible_qpe is relevant here. Feel free to reach out to the community on Slack if you have questions.
We can extend the deadline, how much time do you think you need to complete your contribution?
— Reply to this email directly, view it on GitHubhttps://github.com/Classiq/classiq-library/pull/899#issuecomment-2768538930, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVDV34BA6BXVXK4CS74VD32XJCUXAVCNFSM6AAAAABZ6N7DOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRYGUZTQOJTGA. You are receiving this because you were mentioned.Message ID: @.***>
Adding a new version with new code. We are making checks and cleaning to give an adequate implementation result this Saturday.
Adding a new version with new code. We are making checks and cleaning to give an adequate implementation result this Saturday.
@Dacastillo is it ready for review?
Adding a new version with new code. We are making checks and cleaning to give an adequate implementation result this Saturday.
@Dacastillo is it ready for review?
Hi! The new version is ready, and I'm trying to test this folder to send it to testing. And it fails by timeouts.
adapt_vqe_for_energy_curve.zip
Sorry for the delay. We are trying the best and we still talking to make a more complete work. Greetings.
@Dacastillo Are you still working on this?
Yes, I am. I am finished a prototype notebook. I am struggling with the testing part, making a good enough test file.
@Dacastillo any news here? please feel free to reach out to the community Slack for any questions.
@Dacastillo any news here? please feel free to reach out to the community Slack for any questions.
Thank you for asking. We are finishing our work. We need to see all the library to optimize the process.
Dear @Dacastillo , I took a quick look at the PR, and it does not seem to fit the standards of our library. In particular, the main idea is not clear and the implementation does not seem to relate to Adapt VQE.
We would be happy to help promote this contribution in your personal repository, as well as generally keep supporting your work with Classiq. Thanks!