ClassicPress icon indicating copy to clipboard operation
ClassicPress copied to clipboard

Remove Windows Live Writer action

Open chiotis opened this issue 6 years ago • 8 comments

Let's clean up the

section of our platform. Unless you’re using Windows Live Writer you really don’t need the wlwmanifest_link action. I have already done this in my fork. Let me know if you are ok to make a pull request.

Who is using this thing anyway?

chiotis avatar Sep 19 '18 07:09 chiotis

FYI the commit to review the updates in my fork is https://github.com/chiotis/ClassicPress/commit/15fc2255e3c2fca45569dd12913086c9ea2b14d9

chiotis avatar Sep 19 '18 07:09 chiotis

Thanks, perhaps an idea to get some eyes on this by others in the #core channel on Slack?

senlin avatar Sep 19 '18 07:09 senlin

I have opened a feature request that includes your suggestion, I think it would be good to get some votes on this, so we can go further than just cleaning up the Windows Live Writer :)

senlin avatar Sep 19 '18 08:09 senlin

Overall I am thinking this is not a good fit for v1, where we're trying to make only the minimal changes necessary for a release. We haven't really discussed this change or its possible effects, and I don't think the code itself is ready.

From the linked commit:

Unless you’re using Windows Live Writer you really don’t need the wlwmanifest_link action.

How many people use Windows Live Writer?

Also, if we're removing anything related to WLW, there are lots of other parts of the code that should be removed too:

$ ack '\bwlw\b'
build-branch/wp-includes/wlwmanifest.xml:3:<manifest xmlns="http://schemas.microsoft.com/wlw/manifest/weblog">
build-branch/wp-includes/wlwmanifest.xml:13:    <imageUrl>images/wlw/wp-icon.png</imageUrl>
build-branch/wp-includes/wlwmanifest.xml:14:    <watermarkImageUrl>images/wlw/wp-watermark.png</watermarkImageUrl>
build-branch/wp-includes/wlwmanifest.xml:33:      <imageUrl>images/wlw/wp-comments.png</imageUrl>
build-branch/wp-admin/includes/update-core.php:108:'wp-includes/images/wlw/WpComments.png',
build-branch/wp-admin/includes/update-core.php:109:'wp-includes/images/wlw/WpIcon.png',
build-branch/wp-admin/includes/update-core.php:110:'wp-includes/images/wlw/WpWatermark.png',
build-unminified/wp-includes/wlwmanifest.xml:3:<manifest xmlns="http://schemas.microsoft.com/wlw/manifest/weblog">
build-unminified/wp-includes/wlwmanifest.xml:13:    <imageUrl>images/wlw/wp-icon.png</imageUrl>
build-unminified/wp-includes/wlwmanifest.xml:14:    <watermarkImageUrl>images/wlw/wp-watermark.png</watermarkImageUrl>
build-unminified/wp-includes/wlwmanifest.xml:33:      <imageUrl>images/wlw/wp-comments.png</imageUrl>
build-unminified/wp-admin/includes/update-core.php:108:'wp-includes/images/wlw/WpComments.png',
build-unminified/wp-admin/includes/update-core.php:109:'wp-includes/images/wlw/WpIcon.png',
build-unminified/wp-admin/includes/update-core.php:110:'wp-includes/images/wlw/WpWatermark.png',
build-branch-unminified/wp-includes/wlwmanifest.xml:3:<manifest xmlns="http://schemas.microsoft.com/wlw/manifest/weblog">
build-branch-unminified/wp-includes/wlwmanifest.xml:13:    <imageUrl>images/wlw/wp-icon.png</imageUrl>
build-branch-unminified/wp-includes/wlwmanifest.xml:14:    <watermarkImageUrl>images/wlw/wp-watermark.png</watermarkImageUrl>
build-branch-unminified/wp-includes/wlwmanifest.xml:33:      <imageUrl>images/wlw/wp-comments.png</imageUrl>
build-branch-unminified/wp-admin/includes/update-core.php:108:'wp-includes/images/wlw/WpComments.png',
build-branch-unminified/wp-admin/includes/update-core.php:109:'wp-includes/images/wlw/WpIcon.png',
build-branch-unminified/wp-admin/includes/update-core.php:110:'wp-includes/images/wlw/WpWatermark.png',
src/wp-includes/wlwmanifest.xml:3:<manifest xmlns="http://schemas.microsoft.com/wlw/manifest/weblog">
src/wp-includes/wlwmanifest.xml:13:    <imageUrl>images/wlw/wp-icon.png</imageUrl>
src/wp-includes/wlwmanifest.xml:14:    <watermarkImageUrl>images/wlw/wp-watermark.png</watermarkImageUrl>
src/wp-includes/wlwmanifest.xml:33:      <imageUrl>images/wlw/wp-comments.png</imageUrl>
src/wp-admin/includes/update-core.php:108:'wp-includes/images/wlw/WpComments.png',
src/wp-admin/includes/update-core.php:109:'wp-includes/images/wlw/WpIcon.png',
src/wp-admin/includes/update-core.php:110:'wp-includes/images/wlw/WpWatermark.png',

nylen avatar Oct 17 '18 20:10 nylen

The feature request we opened and that included this option only has 14 votes so far, so I agree to close this until there are enough votes that support removal.

senlin avatar Oct 17 '18 20:10 senlin

For what it's worth, I think that feature request is probably too broad to be actionable as-is, and we'll need to split it apart into smaller issues (like this one) before doing anything.

We could mark this one as "postponed until v2", or close it with the understanding that it can be revisited later. I don't have a strong preference here, just trying to clean up the issues list for v1 as there is already plenty to do.

nylen avatar Oct 17 '18 21:10 nylen

Thanks for the label change, that's better.

nylen avatar Oct 18 '18 04:10 nylen

This issue has been mentioned on ClassicPress Forums. There might be relevant details there:

https://forums.classicpress.net/t/cleaning-up-the-head/2734/1

ClassyBot avatar Dec 30 '20 20:12 ClassyBot