Andrey

Results 75 comments of Andrey

We could set ambitious limits. Although, the number does not sound round to me. Maybe something like 120 * X? Also, significant numbers would be an excellent way to heat...

This error comes from the helper for the typing, this file should not be executed during script parsing. I'd recommend one of: - exclude files started from underscore, - exclude...

> Can we use execution context to conditionally import those files? Not sure what you mean. This file should not be imported during FOCS parsing. It's imported inside the pyi...

Actually I'd prefer to include `typing` module in Python on Windows. It would be nice to use it in macros.

Since we are trying to preserve the old FOCS naming style, the current change looks more compatible. All definitions are already converted, and we still need to change some txt...

@geoffthemedio , @o01eg what do you think? https://github.com/freeorion/freeorion/pull/4726#issuecomment-1704417882

@geoffthemedio , @o01eg what do you think https://github.com/freeorion/freeorion/pull/4726#issuecomment-1704417882?

> I gave a suggestion above, and don't think it's so important to remain consistent with previous naming. Without any documentation, it's sometimes hard to guess, what should be used....

I won't move forward with renaming, until finish with the species conversion. I want to avoid conflicts.

> hmm judging by the linter test failing, this note in test_tech_integrity: "Any error is displayed in chat window." is simply not true, or out of date. I have fixed...