Andrey

Results 75 comments of Andrey

Please add a comment to PR with the following: - test output in logs - example of the test failures for generated tests and for handwritten

@Morlic-fo, Bump!

git is a good example of error messages. ``` > git push fatal: The current branch my_branch has no upstream branch. To push the current branch and set the remote...

> In that case we should provide checksums for every component so test could compare it and give more details. I'd say we could start just from instructions. You have...

@o01eg , you can just add a simple note: is in transition from fo-scripts to Python. During the transition period, we support both of them. You have changed the ,...

```python policy_diversity_threshold = get_named_int("PLC_DIVERSITY_THRESHOLD") ``` This is executed during the import, which might not work. Let's move this thing together first and later try to make it better. I think...

> It works now, I've tested it. That was exactly the idea behind https://github.com/freeorion/freeorion/pull/3936 Pushed some samples. The error message looks like that: ``` 23:26:18.261087 {0x00003298} [error] python : value_references.py:48...

@Grummel7 could you take a look? Docstring allows to write test much easier in simple cases.

> Are modules independent of each other to make tests from command line possible? Dependency on each other is not usually a problem, but dependency on freeorion boost libs is....

> AI Unit test https://github.com/freeorion/freeorion/pull/2431 as test driven development, Will take look into that PR, totally forgot about it. TTD is the process of writing tests. I am not sure...