Abedin Halilovic

Results 18 comments of Abedin Halilovic

> While it works, it kinda feels really complex. Can you walk us through the implementation? > > Also is it possible to provide test suite for such critical part...

> on review, it appears only certain fields are intercepted. > > the line items and any data within the text area's are not triggering the modal. @turbo124 Yeah, I...

@beganovich @turbo124 The PR now includes the fixes we discussed, along with fixes to the tests so we can run them locally at any time to check for any issues....

> tinymce input is not being triggered for this action. also need to ensure any inputs in text area in the line items are also captured. @turbo124 Ah, great catch!...

@turbo124 The implementation for combining DND for columns/task statuses and cards/tasks has been completed. Let me know your thoughts.

> Looks like it's behaving weird... same behavior on FF and Chrome (latest versions). > > Screencast.from.2024-05-07.19-18-26.mp4 @beganovich Ah, great catch. The reason for this behavior is that I used...

> @Civolilah can you toggle this to completed if done / link to pr @turbo124 Yes, this is already resolved, so I'm moving it to done!

@beganovich @turbo124 David made a PR today to fix actions, added some .env variables, and set up some other small things, but for some reason it still does not work....

> @Civolilah is this still draft? @beganovich Yes, David and I worked on fixing GitHub actions to ensure the tests work the same as locally. We encountered a small problem...

@HiloKC Thanks for your advices! The issue will be fixed. However, you also mentioned rounding the unit_cost to more than 2 decimals, which is the default. In the Settings >...