cmake-tools.nvim
cmake-tools.nvim copied to clipboard
feat: initial testing of lockfile and coroutine onexit implementation
so this is initial version of lockfile on_exit implementation, it seems to work i just want to share the progress TODO:
- i'll move lock_file functions to utils and parametrize them
- remove dump from 3rd line
- remove temporary sleep 5 command
- remove special treatment of that full_cmd and implement on_exit properly
- tests
if i'm missing something then please tell me
Seems right to me.
i added hardcoded 0 to on_exit() in terminal for now, but i'm thinking that we could store command exit code in another file so we could get it after
also why don't runners have any callbacks?
Executors are used for cmake-rated commands, including generate, build, install, clean, etc. Runners are used for running executables. Now the end of the progress is Runner, eg, Executor(generate->build)->Runner(execute). So runners do not need callbacks.
i think it might be complete. i'll use it a bit so i'm sure everything works as intended. i added a few local functions to terminal because i didn't feel like they should be exposed outside and local/private functions are way safer to modify without breaking peoples configs. i'm also wondering if calling those files "tmp" is okay.
i'm also wondering if calling those files "tmp" is okay.
I think we should call it cmake_tools_lockfile
LGTM. Thanks for your fantastic work!