bdit_data-sources icon indicating copy to clipboard operation
bdit_data-sources copied to clipboard

#505 WYS null fixes

Open chmnata opened this issue 1 year ago • 2 comments

What this pull request accomplishes:

  • fix null values issues

Issue(s) this solves:

  • #505

What, in particular, needs to reviewed:

  • New sql
  • Some changes to the api script, updating comments, and changing some sql formatting

Will test the dag and function first

chmnata avatar Oct 17 '22 20:10 chmnata

[2022-10-21 17:20:56,766] {wys_api.py:280} ERROR - unsupported operand type(s) for +: 'JSONDecodeError' and 'Response'
[2022-10-21 17:20:56,779] {wys_api.py:280} ERROR - unsupported operand type(s) for +: 'JSONDecodeError' and 'Response'
[2022-10-21 17:20:56,791] {wys_api.py:280} ERROR - unsupported operand type(s) for +: 'JSONDecodeError' and 'Response'

mystery Jsondecodeerror

chmnata avatar Oct 27 '22 19:10 chmnata

That's being thrown by this

https://github.com/CityofToronto/bdit_data-sources/blob/2b391344b57fac1875cbd492c56bfc429a8e72a3/wys/api/python/wys_api.py#L114-L119

Which is getting caught and logged here

https://github.com/CityofToronto/bdit_data-sources/blob/2b391344b57fac1875cbd492c56bfc429a8e72a3/wys/api/python/wys_api.py#L279-L280

radumas avatar Oct 27 '22 20:10 radumas

This branch contains all the modifications that were done in the following branches/PR. It should be safe to merge this branch with the master branch

tahaislam avatar Feb 23 '23 14:02 tahaislam

This branch was merged into #536 and then into master

tahaislam avatar Apr 03 '23 15:04 tahaislam