SODA.NET
SODA.NET copied to clipboard
Dataset Management API Support
This is my first foray into C# and .NET, so any pointers/feedback greatly appreciated. I tried to set up the building blocks based off of https://github.com/socrata/socrata-py
What it adds:
- CreateDataset method through DSMAPI
- CreateRevision off of a currently existing dataset
- Error Rows for catching problematic data
What it removes:
- Nothing
What it could do in the future:
- Column level schema changes on dataset creation/revision
- Using Config (similar to socrata-py)
- Metadata only dataset updates
- Create revision based off external link, the current dataset, or a Gateway
General : Run FxCop on this code base (or some more modern analog) https://docs.microsoft.com/en-us/previous-versions/dotnet/netframework-3.0/bb429476(v=vs.80)?redirectedfrom=MSDN also run https://github.com/StyleCop
File : SODA.Tests/SodcaClientTests.cs
- From the readme it looks like we are renaming DSMAPI intannces to SODAClient. Here we are naming tests with DSMAPI in them and I wonder if we should convert to using SODAClient throughout? File : SODA/SodaClient.cs
- Some instances where you use str == null to check values when its probably ok to use the IsNullOrEmpty() function as you do in other locations
File : README.md
- you can use this formulation to avoid all the extra escape chars in your example code : string path1 = @"c:\temp\MyTest.txt";
File : SODA/PipelineJob.cs
- public string Username => publis string username to match other variable use in the files.
@PeterAustinMoore this is a tremendous effort, thank you for submitting the PR!
I haven't had the time to fully dig in and review yet, but I wanted to let you know its on our radar. One thing that would greatly help the review is if you could rebase
your branch on master
(we had some in-flight changes that were just released yesterday).
I can't promise when we'll get to this, but we are definitely interested in folding in the functionality. Stay tuned!