neo-go-sdk icon indicating copy to clipboard operation
neo-go-sdk copied to clipboard

Published 20 hours ago • verified publisher icon CityOfZion

Generate new PrivateKey

Open maier-stefan opened this issue 7 years ago • 7 comments

Problem

As a User I want to be able to generate a new Private key, since the Struct (PrivateKey) doesn't allow me to generate a private key outside this lib.

Based on that private key Iwant also to be able to create the WIF to use the other functionality of this Codebase.

Solution

Added 2 functions for private key to generate the necessary keys.

maier-stefan avatar Jan 14 '18 11:01 maier-stefan

@revett client_test are failing not knowing why, since i didn't touched them.

maier-stefan avatar Jan 14 '18 12:01 maier-stefan

@Stefflan00 Thanks for the PR! The client.go tests fail randomly due to using live nodes.

We're moving to a faked RPC node within a Docker container soon. Best to re-run if possible.

revett avatar Jan 15 '18 21:01 revett

@Stefflan00 Can you update the CHANGELOG as well please 👍

revett avatar Jan 15 '18 21:01 revett

@revett thanks for taking the time for the review. I did the changes as requested. I still have the tests failing and I'm not able to rerun the test in circle ci since i have no permissions to do so. Can you please either enable me to do so or rerun the test yourself. Thanks again. Looking forward to contribute more to this repo.

maier-stefan avatar Jan 16 '18 09:01 maier-stefan

@Stefflan00 Thanks for doing the changes. I'm working on a PR to fix the tests now. I'll merge that first and then you can rebase the changes into this PR 👍

revett avatar Jan 16 '18 11:01 revett

@Stefflan00 Sorry about the delay. https://github.com/CityOfZion/neo-go-sdk/pull/26 has now been merged so if you pull the changes into your branch, then your tests will pass.

Then we can release 🎉

revett avatar Jan 22 '18 22:01 revett

@revett i think its ready to merge

maier-stefan avatar Jan 30 '18 12:01 maier-stefan