OzoneWalletIOS icon indicating copy to clipboard operation
OzoneWalletIOS copied to clipboard

Fixes AssetCell + Refactors Currency Settings and fixes Title

Open tiagoalmeida opened this issue 6 years ago • 2 comments

I was exploring the code on the wallet and noticed this:

simulator screen shot - iphone 6 - 2018-05-04 at 19 52 45

Therefore, I tried to fix that issue.

While I was doing this, and exploring the code I have also had trouble compiling and running, and added those fixes as well. The only thing that I wasn't able to fix was the Info.plist. Xcode says that Info.plist is in the wrong format in the current master branch. I added one of my own so I was able to work.

Since I was fixing the issue I made a small refactor in CurrencyTableViewController.

Improvements

As a side note I believe that selecting + going back is an unnecessary step, it would be more simple for the user to simply select and go back automatically (he would see that he selected correctly since it appears in the settings)

tiagoalmeida avatar May 05 '18 14:05 tiagoalmeida

Thanks for checking out the code, and suggesting the change, its certainly a welcome improvement Im most actively maintaining this branch right now

https://github.com/O3Labs/OzoneWalletIOS

^ This is the distributed version. Can you set the base of this PR to O3Labs head fork?

saltyskip avatar May 07 '18 01:05 saltyskip

@saltyskip Done. Should I close this one?

PS: As a side note it would be useful if the README from this repository had the information that the most up to date version is in O3Labs

tiagoalmeida avatar May 07 '18 10:05 tiagoalmeida