citizenlab icon indicating copy to clipboard operation
citizenlab copied to clipboard

TAN-2792: Turn on unnecessary lint rule

Open EdwinKato opened this issue 1 year ago • 2 comments

Changelog

Technical

  • This updates the ESLint configuration to enforce the @typescript-eslint/no-unnecessary-condition rule as an error. This rule helps identify conditions that are always truthy or falsy based on TypeScript's type analysis, ensuring that our code is more accurate and free of unnecessary checks. For now, most current violations have been commented out but we can phase them out as we edit these files

EdwinKato avatar Oct 21 '24 07:10 EdwinKato

Messages
:book: Changelog provided 🎉
:book: Notion issue: TAN-2792
:book:

Run the e2e tests

:book: Check translation progress

Generated by :no_entry_sign: dangerJS against 5d6e6f497d2dd9f1ddf9e848cd4ef5296b83e125

cl-dev-bot avatar Oct 21 '24 07:10 cl-dev-bot