citizenlab icon indicating copy to clipboard operation
citizenlab copied to clipboard

TAN-2358: Refactor project cards

Open EdwinKato opened this issue 1 year ago • 3 comments

Changelog

Technical

  • Refactor project card
  • Use list for displaying multiple elements in the project card

EdwinKato avatar Jul 25 '24 13:07 EdwinKato

Messages
:book: Changelog provided 🎉
:book: Jira issue: TAN-2358
:book:

Run the e2e tests

:book: Check translation progress

Generated by :no_entry_sign: dangerJS against 6e3c2dbc66b17b0e94a4f013016cea6228f52409

cl-dev-bot avatar Jul 26 '24 13:07 cl-dev-bot

The key refactor here has been separating the large, small and medium cards into their own components. This will allow to style them in the components where they are used. Before this, the styles within the cards made them hard to style in the parent components where they are used.

  • There is still some repetition and room for improvement but this is a start. Hopefully we could get rid of the medium card in future. It has only one usage and I think we could combine that and the small card and have two layouts for cards. The large one with the image on the left and the one with everything laid out vertically.

EdwinKato avatar Jul 30 '24 06:07 EdwinKato

Closing this. I haven't had time to work on the recommendations and I'm pretty sure the code has changed in ways that would require me to re-do most of the work

EdwinKato avatar Feb 13 '25 08:02 EdwinKato