citizenlab
citizenlab copied to clipboard
Move some user code to concerns
Concerns are not perfect. They do not really isolate the code but still separate it into different files, which makes it hard to connect the dots sometimes.
But in this case, these two pieces of logic (groups and roles) are not connected to the rest of the User
code. And more importantly, the length of User
went out of control. It was hard to grasp what it does in general, hard to navigate through its methods, and even hard to breathe just looking at it.
Oh, but you do have a linting issue
Warnings | |
---|---|
:warning: |
The changelog is empty. What should I put in the changelog? |
:warning: | The PR title contains no Jira issue key (case-sensitive) |
:warning: | The branch name contains no Jira issue key (case-sensitive) |
Messages | |
---|---|
:book: | |
:book: | Check translation progress |
Generated by :no_entry_sign: dangerJS against 98e41276e449684505b89310f84eee723ce8853b