citizenlab icon indicating copy to clipboard operation
citizenlab copied to clipboard

TAN-1794 - FormSync / XLSX - return async errors

Open jamesspeake opened this issue 9 months ago • 3 comments

Errors now look like this - I've tweaked text to make it clearer. Second image shows errors we don't specifically catch - but don't expect these to happen often. image

image

Could not get it to only throw errors for those ideas that have failed - this would be too big a refactor right now.

Changelog

Changed

  • XLSX/PDF import now return the errors being thrown within the Async job to give a clearer picture when something goes wrong

jamesspeake avatar May 07 '24 14:05 jamesspeake

Warnings
:warning: The PR title contains no Jira issue key (case-sensitive)
:warning: The branch name contains no Jira issue key (case-sensitive)
Messages
:book: Changelog provided 🎉
:book:

Run the e2e tests

:book: Check translation progress

Generated by :no_entry_sign: dangerJS against 199c924e142694db7900cdbd522a024265830ebd

cl-dev-bot avatar May 07 '24 15:05 cl-dev-bot

Maybe I would prefer if last_error_message returned a nice and clean string that can be immediately used by FE.

I've just updated this logic to the backend. There is now a method in the controller to return a generic 'uncaught_error' if it's not a recognised error string. Do you want to take a quick look @alexander-cit ?

jamesspeake avatar May 08 '24 14:05 jamesspeake