citizenlab
citizenlab copied to clipboard
CitizenLabDotCo
[TAN-1673] Fix template details button
Description
When I was looking into this issue, I realized how weird the code was for the project template "more details" page. It's not really a separate route, it's a modal I think? The back button or "More templates" behaviour doesn't actually bring you to the right page either, it sends you back to the "All projects" view. The code itself is also using event emitters and a bunch of window functions which was strange.
Rob has approved the change to make the "more details" page into a large modal instead, so opening/closing the details view lets you remain on the same page (I think this is a much better UX) :+1:
I also removed the messy existing code from the codebase.
Changelog
Fixed
- [TAN-1673] Fixed broken project template "More details" button.
![notion-workspace[bot] avatar](https://avatars.githubusercontent.com/in/300037?v=4 "Published by a pub.dev verified publisher"){kind=small}
| Warnings | |
|---|---|
| :warning: | The PR title contains no Jira issue key (case-sensitive) |
| :warning: | The branch name contains no Jira issue key (case-sensitive) |
| Messages | |
|---|---|
| :book: | Changelog provided 🎉 |
| :book: | |
| :book: | Check translation progress |
Generated by :no_entry_sign: dangerJS against 4674a0af04d4c7dec2b1cad12bf5f48e003f451c
Only failure was a back-bundle-audit, which is also on master, so I've merged this.