citizenlab
citizenlab copied to clipboard
CitizenLabDotCo
Put back centering of survey fields
- Centers content of survey form vertically (without adding styles to the generic Form component) when there's only one field or just a title/description such as on the "Thank you" page
- Moved progress bar to bottom of survey, above the previous/next buttons
- Cleanup and simplification of survey form (although it's still too complicated imo)
| Warnings | |
|---|---|
| :warning: |
The changelog is empty. What should I put in the changelog? |
| :warning: | The PR title contains no Jira issue key (case-sensitive) |
| :warning: | The branch name contains no Jira issue key (case-sensitive) |
| Messages | |
|---|---|
| :book: | |
| :book: | Check translation progress |
Generated by :no_entry_sign: dangerJS against 9432e223a7aeb8b17accb3c446f81d46fbe04a7d
@brentguf Looks simpler from just the code 👏 👏 . There are a few pain points with styling the survey that I intended to fix in my 10% but I'm glad you're already doing it 💪. I'll do a deeper review later but let's merge in all the work from master. That will make it easier to review holistically. I know of a few gotchas that I want to test out.
FYI, there was a layout bug on mobile that Amanda fixed where some fields were hidden on some mobile layouts. Amanda fixed that by removing centering on mobile for now after consulting with Rob. If this centers and fixes it, that would be really nice. If not, then it is not a requirement for this
@EdwinKato Note this doesn't have new changes since your last review/comment, besides the PR I just merged (which you reviewed).
@EdwinKato, if you've checked the gotchas, please approve if there are no further remarks!