CitizenLabDotCo
Basic layout full-width login/signin screen
Checklist
- [ ] Added entry to changelog
More info
Add a concise line to the 'Next release' section of the changelog (docs/README.md) so people other than developers can understand what has changed where. E.g. 'Added an error message to the project name field of the project edit form (Admin > Projects > Edit)'.- [ ] WCAG 2.1 AA proof
More info
For front-end devs only. Is your work conforming with the WCAG 2.1 AA rules? If you need more info, read the [a11y page](https://www.notion.so/citizenlab/a11y-7568f83d42ab4895ac133b89d358997b) on our Notion.- [ ] Tests
More info
Unit tests
Did you add relevant unit tests?
E2E tests
Sometimes it can be more efficient to update E2E tests after CI has run them. If you know which ones to update, go ahead! E2E template cl2-back:
docker compose run --rm web bin/rails cl2_back:create_tenant[localhost,e2etests_template]
- [ ] Prepared branch for code review
More info
Reviewed code to reduce unnecessary back and forth (removal of console.log, comments, ...)? Added comments to clarify code, emphasize what to pay attention to, etc.?Links
- [citizenlab-ee PR](put URL here or remove)
- [Specs](put URL here or remove)
- [Epic Deployment](put URL here or remove)
How urgent is a code review?
Let the reviewer(s) know how urgent the code review is, so they can prioritize their work accordingly. Be specific (e.g. by Wednesday, end of the day/this week/... is better than 'urgent' or 'very urgent'). Optionally provide a word of explanation on your deadline.
| Warnings | |
|---|---|
| :warning: | The PR title contains no Jira issue key (case-sensitive) |
| :warning: | The changelog hasn't been modified |
| Messages | |
|---|---|
| :book: | |
| :book: | Jira issue: CL-1101 |
Generated by :no_entry_sign: dangerJS against f60dbc69c597a3d38830b9b0bd6346605ce4256a
Some preliminary feedback - renaming imports and moving files can be useful, but it can also greatly increase the size of the diff. I'm looking into the work here so I can pick it up and continue with it, but the diff and commits are already pretty large. I understand wanting to leave code better than you found it, but also keep in mind the cognitive load of taking over a PR with 56 commits and 100 changed files
For reference, updates were posted in this slack thread: https://citizenlabco.slack.com/archives/C01NLAC43T3/p1667577394080699?thread_ts=1667577387.445469&cid=C01NLAC43T3
I worked with Alex on this one, we decided to continue some work he'd started previously to solve the problem in this PR. Since this involves the signin/signup flow, I wanted to touch as few files as possible, and fix this with minimal styling changes instead of changes to the underlying layout of the components. If there's code in this PR you'd still like to merge to master, feel free to update the PR and re-request a review