citizenlab icon indicating copy to clipboard operation
citizenlab copied to clipboard

CL-423 Analytics engine

Open adessy opened this issue 2 years ago • 3 comments

Checklist

  • [ ] Added entry to changelog
More info Add a concise line to the 'Next release' section of the changelog (docs/README.md) so people other than developers can understand what has changed where. E.g. 'Added an error message to the project name field of the project edit form (Admin > Projects > Edit)'.
  • [ ] WCAG 2.1 AA proof
More info For front-end devs only. Is your work conforming with the WCAG 2.1 AA rules? If you need more info, read the [a11y page](https://www.notion.so/citizenlab/a11y-7568f83d42ab4895ac133b89d358997b) on our Notion.
  • [ ] Tests
More info

Unit tests

Did you add relevant unit tests?

E2E tests

Sometimes it can be more efficient to update E2E tests after CI has run them. If you know which ones to update, go ahead! E2E template cl2-back:

docker compose run --rm web bin/rails cl2_back:create_tenant[localhost,e2etests_template]
  • [ ] Prepared branch for code review
More info Reviewed code to reduce unnecessary back and forth (removal of console.log, comments, ...)? Added comments to clarify code, emphasize what to pay attention to, etc.?

Links

  • [citizenlab-ee PR](put URL here or remove)
  • [Specs](put URL here or remove)
  • [Epic Deployment](put URL here or remove)

How urgent is a code review?

Let the reviewer(s) know how urgent the code review is, so they can prioritize their work accordingly. Be specific (e.g. by Wednesday, end of the day/this week/... is better than 'urgent' or 'very urgent'). Optionally provide a word of explanation on your deadline.

adessy avatar Jul 04 '22 15:07 adessy

Messages
:book: Jira issue: CL-423

Generated by :no_entry_sign: dangerJS against 56814d8448cfe44da0fbc4cedc99a91dba05520c

cl-dev-bot avatar Jul 05 '22 13:07 cl-dev-bot

@adessy can you review this? i can't assign you since you created the PR i think thankss!

franciclo avatar Aug 02 '22 22:08 franciclo