citizenlab icon indicating copy to clipboard operation
citizenlab copied to clipboard

CL-900 Remove required attributes from json schema to permit deletion of related data

Open jinjagit opened this issue 3 years ago • 3 comments

  • [ ] Prepared branch for code review

Description

We need to remove the "enabled" (for example, for the events_widget) from "required": ["allowed", "enabled"], in back/config/schemas/settings.schema.json.erb before we delete the enabled key/value pair from AppConfiguration.settings (as is done in this PR), but we cannot delete the related property…

"properties": {
  ...,
  "enabled": { "type": "boolean", "default": true}
}

… until after the data deletion (as the property will exist, and therefore needs to be in the schema, before it is deleted by the task). There may be more similar cases than just the 2 "enabled" booleans.

Links

jinjagit avatar Jun 22 '22 15:06 jinjagit

I think we have to merge this into master, not CL-5_flexible_pages_iteration_1. The epic branch has been merged already.

nTraum avatar Jun 24 '22 06:06 nTraum

I think we have to merge this into master, not CL-5_flexible_pages_iteration_1. The epic branch has been merged already.

Yes, that's probably true. CL-5 wasn't merged into master when I started this.

jinjagit avatar Jun 24 '22 08:06 jinjagit

Warnings
:warning: The changelog hasn't been modified
Messages
:book: Jira issue: CL-900

Generated by :no_entry_sign: dangerJS against d7a0dcc251408baa97e6b57905e128f14f7bc2a9

cl-dev-bot avatar Jul 19 '22 16:07 cl-dev-bot